Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting/Fn Tests] Unskip Screenshot Tests #78190

Merged
merged 5 commits into from
Sep 24, 2020
Merged

[Reporting/Fn Tests] Unskip Screenshot Tests #78190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a2954ec
[Reporting/Fn Tests] Wait longer for reports to finish
tsullivan Sep 22, 2020
3426aa7
Merge branch 'master' into reporting/unskip-screenshot-tests
elasticmachine Sep 23, 2020
f4226ee
Merge branch 'master' into reporting/unskip-screenshot-tests
elasticmachine Sep 23, 2020
13c6b80
Merge branch 'master' into reporting/unskip-screenshot-tests
elasticmachine Sep 23, 2020
d9a5a67
Merge branch 'master' into reporting/unskip-screenshot-tests
elasticmachine Sep 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/test/reporting_api_integration/reporting_and_security/network_policy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export default function ({ getService }: FtrProviderContext) {
filter(({ statusCode }) => statusCode === 500),
map(({ message }) => message),
first(),
timeout(15000)
timeout(120000)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not related to a test that is currently failing, but the value was still way too low and was on the cusp of being flaky.

One of the reasons being very low was acceptable in this test is that the use case it covers has bug which makes it fail early instead of going through the usual 3 attempts to complete a report.

);

const reportFailed = await fails$.toPromise();
Expand Down
8 changes: 3 additions & 5 deletions x-pack/test/reporting_api_integration/reporting_and_security/spaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export default function ({ getService }: FtrProviderContext) {
tap(() => log.debug(`report at ${downloadPath} is done`)),
map((response) => response.text),
first(),
timeout(15000)
timeout(120000)
);
};

Expand Down Expand Up @@ -105,8 +105,7 @@ export default function ({ getService }: FtrProviderContext) {
});
});

// FLAKY: https://github.com/elastic/kibana/issues/76551
it.skip('should complete a job of PNG export of a dashboard in non-default space', async () => {
it('should complete a job of PNG export of a dashboard in non-default space', async () => {
const downloadPath = await reportingAPI.postJobJSON(
`/s/non_default_space/api/reporting/generate/png`,
{
Expand All @@ -119,8 +118,7 @@ export default function ({ getService }: FtrProviderContext) {
expect(reportCompleted).to.not.be(null);
});

// FLAKY: https://github.com/elastic/kibana/issues/76551
it.skip('should complete a job of PDF export of a dashboard in non-default space', async () => {
it('should complete a job of PDF export of a dashboard in non-default space', async () => {
const downloadPath = await reportingAPI.postJobJSON(
`/s/non_default_space/api/reporting/generate/printablePdf`,
{
Expand Down
6 changes: 2 additions & 4 deletions x-pack/test/reporting_api_integration/reporting_and_security/usage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,7 @@ export default function ({ getService }: FtrProviderContext) {
reportingAPI.expectRecentJobTypeTotalStats(usage, 'printable_pdf', 0);
});

// FLAKY: https://github.com/elastic/kibana/issues/76581
it.skip('should handle preserve_layout pdf', async () => {
it('should handle preserve_layout pdf', async () => {
await reportingAPI.expectAllJobsToFinishSuccessfully(
await Promise.all([
reportingAPI.postJob(GenerationUrls.PDF_PRESERVE_DASHBOARD_FILTER_6_3),
Expand All @@ -150,8 +149,7 @@ export default function ({ getService }: FtrProviderContext) {
reportingAPI.expectRecentJobTypeTotalStats(usage, 'printable_pdf', 2);
});

// FLAKY: https://github.com/elastic/kibana/issues/76581
it.skip('should handle print_layout pdf', async () => {
it('should handle print_layout pdf', async () => {
await reportingAPI.expectAllJobsToFinishSuccessfully(
await Promise.all([
reportingAPI.postJob(GenerationUrls.PDF_PRINT_DASHBOARD_6_3),
Expand Down