Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Resolver] add comments. #78301

Merged
merged 1 commit into from
Sep 23, 2020
Merged

[Resolver] add comments. #78301

merged 1 commit into from
Sep 23, 2020

Conversation

oatkiller
Copy link
Contributor

@oatkiller oatkiller commented Sep 23, 2020 •
edited
Loading

Summary

Follow up to #77928

Adds a few comments and a isFinite check.

Screenshots

Still works. No expected change in behavior.

image

For maintainers

@oatkiller oatkiller requested review from a team as code owners September 23, 2020 14:33
@oatkiller oatkiller added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 23, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 10.2MB +48.0B 10.2MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

bkimmel
bkimmel approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@bkimmel bkimmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@oatkiller oatkiller merged commit cb451cd into elastic:master Sep 23, 2020
@oatkiller oatkiller deleted the refactor-panel-view-cleanup branch September 23, 2020 17:26
@oatkiller oatkiller mentioned this pull request Sep 23, 2020
Closed
oatkiller pushed a commit to oatkiller/kibana that referenced this pull request Sep 23, 2020
[Resolver] add comments. (elastic#78301)
a1bb955
@oatkiller oatkiller mentioned this pull request Sep 23, 2020
Merged
oatkiller pushed a commit to oatkiller/kibana that referenced this pull request Sep 23, 2020
[Resolver] add comments. (elastic#78301)
f146265
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added backport missing Added to PRs automatically when the are determined to be missing a backport. and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Sep 25, 2020
oatkiller pushed a commit that referenced this pull request Sep 28, 2020
@elasticmachine
[Resolver] add comments. (#78301) (#78333)
41be0f3 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelolo24 michaelolo24 michaelolo24 approved these changes

@bkimmel bkimmel bkimmel approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oatkiller @kibanamachine @bkimmel @michaelolo24