[Functional] Wait for the page to load and then click the new vis button #78725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
added
Feature:Visualizations
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
stratoula
added
the
failed-test
|
Pinging @elastic/kibana-test-triage (failed-test) |
stratoula
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
dmlemeshko
approved these changes
Sep 30, 2020
There was a problem hiding this comment.
In QA team we discussed that checking header state (loaded/ not loaded) does not guarantee other components are rendered, but it gives extra 1-2 seconds while it searches for an element and most of the time it is enough.
Since I don't have a better solution, I agree with changes.
Might be good to research and add some attribute in component that renders viz list.
|
Good point @dmlemeshko. Let's see if the extra time helps here else will wait for the list to be loaded. |
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Sep 30, 2020
stratoula
added a commit
that referenced
this pull request
Sep 30, 2020
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Sep 30, 2020
…aly-detection-partition-field * 'master' of github.com:elastic/kibana: (37 commits) [UiActions] Don't throw an error if there are no compatible actions to execute (elastic#78917) [Observability] Kibana nav when docked overlaps the content of the pages. (elastic#78593) Invalid `searchSourceJSON` causes saved object migration to fail (elastic#78535) update vega version (elastic#78390) Fix warning text doesn't get displayed on filters with custom filter name (elastic#78617) [ILM] Data tier notices should reflect tier preferences (elastic#78398) [APM] Service Map: `Not Defined` option doesn't work properly (elastic#77757) Improve invalid field error message at search.aggs.param_types.field (elastic#78587) Remove isDeprecated flag on visType (elastic#78820) Remove unused elasticsearch.preserverHost setting (elastic#78608) Fix condition and adjust tests (elastic#78898) [UX] Add percentile selector (elastic#78562) [ML] Replace use of rest_total_hits_as_int with track_total_hits (elastic#78423) expression service docs (elastic#78774) [Functional] Wait for the page to load and then click the new vis button (elastic#78725) [TSVB] No data in visualizations with annotations (elastic#78794) [kbn/ui-shared-deps] track asset sizes (elastic#78718) delete target before building (elastic#78665) Move indexPattern.popularizeField into discover (elastic#77668) [Security Solution][Resolver]Add backdrop to pills (elastic#78625) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #77169
Closes #77168
Both functional tests use the same function to locate the "Create new vis" button. They don't fail a lot, it seems that the problem is that the page hasn't loaded yet so the button can't be located. So I will wait for the page to load and then call the function which locates the button. The
clickNewVisualizationalready has a retry so I think that this fix will cover all the failures.Test runner 100 times, 50 times for the point series and 50 times for the vertical bar.
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/857/
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/856/
Checklist