Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce bundle size of the default editor #78938

Merged
merged 3 commits into from
Oct 1, 2020
Merged

Reduce bundle size of the default editor #78938

merged 3 commits into from
Oct 1, 2020

Conversation

sulemanof
Copy link
Contributor

@sulemanof sulemanof commented Sep 30, 2020 •
edited
Loading

Summary

This reduces initial bundle size of vis_default_editor plugin to ≈60kb by moving the Data tab component to be lazy loaded inside the sidebar.

default_editor_chunk_size

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@sulemanof sulemanof added Feature:Vis Editor Visualization editor issues release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0 labels Sep 30, 2020
@sulemanof sulemanof marked this pull request as ready for review September 30, 2020 13:54
@sulemanof sulemanof requested a review from a team September 30, 2020 13:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor

@elasticmachine merge upstream

flash1293
flash1293 approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Safari and still works as expected, LGTM

src/plugins/vis_default_editor/public/components/sidebar/use_option_tabs.ts Outdated Show resolved Hide resolved
alexwizp
alexwizp approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested locally

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
visDefaultEditor 238 239 +1

async chunks size

id before after diff
visDefaultEditor 44.8KB 409.7KB ⚠️ +364.9KB

distributable file count

id before after diff
default 45831 45834 +3
oss 26554 26557 +3

page load bundle size

id before after diff
visDefaultEditor 397.8KB 34.4KB -363.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

stratoula
stratoula approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

@timroes timroes merged commit 8f89ef5 into elastic:master Oct 1, 2020
@sulemanof sulemanof deleted the fix/default_editor_bundle_size branch October 1, 2020 12:27
sulemanof added a commit to sulemanof/kibana that referenced this pull request Oct 1, 2020
@sulemanof @elasticmachine
Reduce bundle size of the default editor (elastic#78938)
fafefbf 
* Reduce bundle size

* Remove useless line of code

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@sulemanof sulemanof mentioned this pull request Oct 1, 2020
Merged
sulemanof added a commit that referenced this pull request Oct 1, 2020
@sulemanof @elasticmachine
Reduce bundle size of the default editor (#78938) (#79107)
75322d4 
* Reduce bundle size

* Remove useless line of code

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexwizp alexwizp alexwizp approved these changes

@stratoula stratoula stratoula approved these changes

@flash1293 flash1293 flash1293 approved these changes

@DianaDerevyankina DianaDerevyankina Awaiting requested review from DianaDerevyankina

@timroes timroes Awaiting requested review from timroes

@VladLasitsa VladLasitsa Awaiting requested review from VladLasitsa

Assignees
No one assigned
Labels
Feature:Vis Editor Visualization editor issues release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sulemanof @elasticmachine @flash1293 @kibanamachine @stratoula @alexwizp @timroes