Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Untitled Timeline created when first action is to add note #78988

Merged
merged 16 commits into from
Oct 3, 2020
Merged

[Security Solution] Untitled Timeline created when first action is to add note #78988

merged 16 commits into from
Oct 3, 2020

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Sep 30, 2020 •
edited
Loading

Summary

This PR is to fix
https://github.com/elastic/siem-team/issues/844

Steps to reproduce:

  • Open a new timeline
  • Add a note
  • Go to timelines' page

Before: It creates an untitled timeline and shows in the timelines table.

After: It creates a draft timeline and therefore not displaying it in timelines table until putting a title to current timeline.

note2

This PR fixs https://github.com/elastic/security-team/issues/357 too

Steps to Reproduce

Open browser

  • Click on Create timeline button.
  • Click on Favorite icon
  • Go to timelines' page

Before: It creates an untitled timeline and shows in the timelines table.

After: It creates a draft timeline and therefore not displaying it in timelines table until putting a title to current timeline.

fav

@angorayc angorayc closed this Sep 30, 2020
@angorayc angorayc reopened this Sep 30, 2020
@XavierM
Copy link
Contributor

XavierM commented Oct 1, 2020

The way we managed that before was to create the timeline first if need it and then adding a note to the timeline in the backend. DId that change?

@angorayc
Copy link
Contributor Author

angorayc commented Oct 1, 2020 •
edited
Loading

@XavierM That didn't change and. I also found that it's the status didn't set correctly to draft when a timeline/template was created by saving note. It works well after making sure it creates a draft timeline when saving a note.

So @stephmilovic, I gave up the UI fix and roll back to original behaviour, but I think it works correctly now.
note2

@angorayc angorayc added v7.10.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 1, 2020
@angorayc angorayc marked this pull request as ready for review October 1, 2020 15:42
@angorayc angorayc requested review from a team as code owners October 1, 2020 15:42
@angorayc
Copy link
Contributor Author

angorayc commented Oct 1, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@angorayc
Copy link
Contributor Author

angorayc commented Oct 2, 2020

This fixes https://github.com/elastic/security-team/issues/357 as well

fav

XavierM
XavierM approved these changes Oct 3, 2020
View reviewed changes
Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angorayc angorayc merged commit 513ebb5 into elastic:master Oct 3, 2020
@angorayc angorayc mentioned this pull request Oct 3, 2020
Merged
angorayc added a commit to angorayc/kibana that referenced this pull request Oct 3, 2020
@angorayc @elasticmachine
[Security Solution] Untitled Timeline created when first action is to…
2a4ef87 
… add note (elastic#78988)

* init tests

* Untitled Timeline created

* remove console

* fix from server side

* set timeline status to draft if created by saving notes

* add unit test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 5, 2020
@gmmorris
Merge branch 'master' into actions/decouple-actions-from-alertid
d99fe4b 
* master: (128 commits)
  add core-js production dependency (elastic#79395)
  Add support for sharing saved objects to all spaces (elastic#76132)
  [Alerting UI] Display a banner to users when some alerts have failures, added alert statuses column and filters (elastic#79038)
  load js-yaml lazily (elastic#79092)
  skip flaky suite (elastic#77278)
  Fix agentPolicyUpdateEventHandler() to use app context soClient for creation of actions (elastic#79341)
  [Security Solution] Untitled Timeline created when first action is to add note (elastic#78988)
  [Security Solutions][Detection Engine] Updates the edit rules page to:wq! only have what is selected for editing (elastic#79233)
  Cleanup yarn.lock from duplicates (elastic#66617)
  [kbn/optimizer] implement more efficient auto transpilation for node (elastic#79052)
  [Ingest Manager] Rename Fleet setup and requirement, Fleet => Central… (elastic#79291)
  [core/server/plugins] don't run discovery in dev server parent process (take 2) (elastic#79358)
  [babel/register] remove from build (take 2) (elastic#79379)
  [Security Solution] Changes rules table tag display (elastic#77102)
  define integrationTestRoot in config file and use to define screensho… (elastic#79247)
  Revert "[babel/register] remove from build (elastic#79176)"
  skip flaky suite (elastic#75241)
  [Uptime] Synthetics UI (elastic#77960)
  [Security Solution] [Detections] Only display actions options if user has "read" privileges (elastic#78812)
  [babel/register] remove from build (elastic#79176)
  ...
angorayc added a commit that referenced this pull request Oct 5, 2020
@angorayc @elasticmachine @kibanamachine
[Security Solution] Untitled Timeline created when first action is to…
44b8c5c 
… add note (#78988) (#79390)

* init tests

* Untitled Timeline created

* remove console

* fix from server side

* set timeline status to draft if created by saving notes

* add unit test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 5, 2020
@gmmorris
Merge branch 'master' into task-manager/health
7b14dff 
* master: (288 commits)
  add core-js production dependency (elastic#79395)
  Add support for sharing saved objects to all spaces (elastic#76132)
  [Alerting UI] Display a banner to users when some alerts have failures, added alert statuses column and filters (elastic#79038)
  load js-yaml lazily (elastic#79092)
  skip flaky suite (elastic#77278)
  Fix agentPolicyUpdateEventHandler() to use app context soClient for creation of actions (elastic#79341)
  [Security Solution] Untitled Timeline created when first action is to add note (elastic#78988)
  [Security Solutions][Detection Engine] Updates the edit rules page to only have what is selected for editing (elastic#79233)
  Cleanup yarn.lock from duplicates (elastic#66617)
  [kbn/optimizer] implement more efficient auto transpilation for node (elastic#79052)
  [Ingest Manager] Rename Fleet setup and requirement, Fleet => Central… (elastic#79291)
  [core/server/plugins] don't run discovery in dev server parent process (take 2) (elastic#79358)
  [babel/register] remove from build (take 2) (elastic#79379)
  [Security Solution] Changes rules table tag display (elastic#77102)
  define integrationTestRoot in config file and use to define screensho… (elastic#79247)
  Revert "[babel/register] remove from build (elastic#79176)"
  skip flaky suite (elastic#75241)
  [Uptime] Synthetics UI (elastic#77960)
  [Security Solution] [Detections] Only display actions options if user has "read" privileges (elastic#78812)
  [babel/register] remove from build (elastic#79176)
  ...
@angorayc angorayc mentioned this pull request Oct 5, 2020
Merged
angorayc added a commit to angorayc/kibana that referenced this pull request Oct 5, 2020
@angorayc @elasticmachine
[Security Solution] Untitled Timeline created when first action is to…
8b65c18 
… add note (elastic#78988)

* init tests

* Untitled Timeline created

* remove console

* fix from server side

* set timeline status to draft if created by saving notes

* add unit test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
angorayc added a commit that referenced this pull request Oct 5, 2020
@angorayc @elasticmachine
[Security Solution] Untitled Timeline created when first action is to…
7da3f52 
… add note (#78988) (#79424)

* init tests

* Untitled Timeline created

* remove console

* fix from server side

* set timeline status to draft if created by saving notes

* add unit test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@angorayc angorayc added Team:Threat Hunting Security Solution Threat Hunting Team v7.9.3 labels Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierM XavierM XavierM approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v7.9.3 v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@angorayc @XavierM @kibanamachine @elasticmachine