Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Hide service if only data is from ML #80145

Merged
merged 2 commits into from
Oct 15, 2020
Merged

[APM] Hide service if only data is from ML #80145

merged 2 commits into from
Oct 15, 2020

Conversation

dgieselaar
Copy link
Member

Closes #79998.

@dgieselaar dgieselaar added bug Fixes for quality problems that affect the customer experience v7.10.0 labels Oct 12, 2020
@dgieselaar dgieselaar requested a review from a team as a code owner October 12, 2020 12:05
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Oct 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

sorenlouv
sorenlouv reviewed Oct 14, 2020
View reviewed changes
x-pack/test/apm_api_integration/trial/tests/services/top_services.ts

expect(response.body.items.length).to.be(1);

expect(response.body.items[0].serviceName).to.be('opbeans-java');
Copy link
Member

@sorenlouv sorenlouv Oct 14, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this change the list would include other services than "opbeans-java" even though a kuery filter is given?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because the kuery filter is not applied to the ML job.

@dgieselaar
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dgieselaar dgieselaar merged commit 9d50c17 into elastic:master Oct 15, 2020
@dgieselaar dgieselaar deleted the hide-ml-only-services branch October 15, 2020 18:45
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 16, 2020
@gmmorris
Merge branch 'master' into task-manager/refactor-oversized-class
475d49d 
* master: (115 commits)
  [ML] Transforms/DF Analytics: Fix data grid column sorting. (elastic#80618)
  added brace import to vis editor (elastic#80652)
  Fix error rate sorting in services list (elastic#80764)
  Emit info log when using custom registry URL (elastic#80768)
  [Reporting] Config Schema Validation for rules[N].protocol strings (elastic#80766)
  Add Storybook a11y addon (elastic#80069)
  Fix anomaly alert selection text (elastic#80746)
  [Security Solution] [Maps] Kibana index pattern, comma bug fix (elastic#80208)
  [kbn/optimizer] tweak split chunks options (elastic#80444)
  update template to use the new team label (elastic#80748)
  [Security Solution] Fix the Field dropdown in Timeline data providers resets when scrolled (elastic#80718)
  Adjusts observability alerting perms to require "all" (elastic#79896)
  [Security Solutions][Detection Engine] Fixes pre-packaged rules which contain exception lists to not overwrite user defined lists   (elastic#80592)
  [data.ui] Fix flaky test & lazy loading rendering artifacts. (elastic#80612)
  Licensed feature usage for connectors (elastic#77679)
  [Security Solution] Cypress template creation (elastic#80180)
  [APM] Hide service if only data is from ML (elastic#80145)
  Fix role mappings test for ESS (elastic#80604)
  [Maps] Add support for envelope (elastic#80614)
  [Security Solution] Update button text according to status (elastic#80389)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 19, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 80145 or prevent reminders by adding the backport:skip label.

@dgieselaar dgieselaar mentioned this pull request Oct 20, 2020
Merged
dgieselaar added a commit to dgieselaar/kibana that referenced this pull request Oct 20, 2020
@dgieselaar @kibanamachine
[APM] Hide service if only data is from ML (elastic#80145)
ad0ef84 
Closes elastic#79998.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@dgieselaar dgieselaar mentioned this pull request Oct 20, 2020
Merged
dgieselaar added a commit to dgieselaar/kibana that referenced this pull request Oct 20, 2020
@dgieselaar @kibanamachine
[APM] Hide service if only data is from ML (elastic#80145)
445bf9f 
Closes elastic#79998.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
dgieselaar added a commit that referenced this pull request Oct 20, 2020
@dgieselaar @kibanamachine
[7.x] [APM] Hide service if only data is from ML (#80145) (#81127)
3f92188 
Closes #79998.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
dgieselaar added a commit that referenced this pull request Oct 20, 2020
@dgieselaar @kibanamachine
[7.10] [APM] Hide service if only data is from ML (#80145) (#81128)
858eb60 
Closes #79998.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@smith smith smith approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience release_note:fix Team:APM All issues that need APM UI Team support v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Don't display services that don't have APM data for the selected time range
5 participants
@dgieselaar @elasticmachine @kibanamachine @smith @sorenlouv