Use Storybook Controls instead of Knobs #80705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change an example in embeddable to use controls instead of knobs * Add controls to SyncBadge APM story * Convert both to [CSF](https://storybook.js.org/docs/react/api/csf) * Remove the Knobs addon from the default Storybook configuration Do not remove the Knobs addon package, since Canvas is still using it and this does not change anything in Canvas.
smith
added
v8.0.0
release_note:skip
botelastic
bot
added
Feature:Embedding
|
Pinging @elastic/apm-ui (Team:apm) |
ogupte
reviewed
Oct 15, 2020
| import { action } from '@storybook/addon-actions'; | ||
| import { withKnobs, boolean } from '@storybook/addon-knobs'; | ||
| import * as React from 'react'; |
There was a problem hiding this comment.
we can use the default import hereimport React from 'react';. It shouldn't change anything else in this file. or we can copy what you did in SyncBadge.stories.tsx (e.g. import React, { ComponentProps } from 'react';)
There was a problem hiding this comment.
VSCode auto-formatted this for me so I thought maybe this plugin had some lint rules around this. @elastic/kibana-app-arch let me know if there's a preference for react imports here.
ogupte
approved these changes
Oct 15, 2020
|
@elasticmachine merge upstream |
streamich
approved these changes
Oct 21, 2020
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
smith
added a commit
to smith/kibana
that referenced
this pull request
Oct 21, 2020
* Change an example in embeddable to use controls instead of knobs * Add controls to SyncBadge APM story * Convert both to [CSF](https://storybook.js.org/docs/react/api/csf) * Remove the Knobs addon from the default Storybook configuration Do not remove the Knobs addon package, since Canvas is still using it and this does not change anything in Canvas.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 22, 2020
* master: (63 commits) [KP] Fix Headers timeout issue (elastic#81140) [ML] Functional tests - stabilize typing with checks service method (elastic#81338) tabify - support docs (elastic#80351) [Security Solution][Detections] Look-back time logic fix (elastic#81383) [Workplace Search] Add top-level tests for Groups (elastic#81215) [Fleet] Fix agent action observable for long polling (elastic#81376) [Maps] fix feature tooltip remains open when zoom level change hides layer (elastic#81373) skip flaky suite (elastic#78689) chore(NA): add spec-to-console and plugin-helpers as devOnly dependencies (elastic#81357) Ensure some data is returned (elastic#81375) Change dumb-init to tini (elastic#81126) [Reporting/Tech Debt] Convert PdfMaker class to TypeScript (elastic#81242) Use Storybook Controls instead of Knobs (elastic#80705) [junit] make sure that report paths are unique (elastic#81255) bump elastic/elasticsearch-js version to 7.10.0-rc1 (elastic#81288) run ssl tests on CI (elastic#81320) Fix alert defaults (elastic#81207) [ML] DF Analytics wizard: ensure user can set mml manually or select to use given estimate (elastic#81078) Add UI notifier to indicate secret fields and to remember / reenter values (elastic#80657) [Monitoring] Use async/await (elastic#81200) ...
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
1 similar comment
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
removed
the
backport missing
smith
added a commit
that referenced
this pull request
Oct 27, 2020
* Change an example in embeddable to use controls instead of knobs * Add controls to SyncBadge APM story * Convert both to [CSF](https://storybook.js.org/docs/react/api/csf) * Remove the Knobs addon from the default Storybook configuration Do not remove the Knobs addon package, since Canvas is still using it and this does not change anything in Canvas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not remove the Knobs addon package, since Canvas is still using it and this does not change anything in Canvas.