Changed required field data pane width and increased window width for… #8127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… changes in side bar.
|
💯 LGTM |
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Changed required field data pane width and increased window width for… Former-commit-id: 132dbdf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8121
The main navigation bar on the left is now expanded by default and has a button to collapse/expand.
The Discover tab's field data panel width must be a percentage (or somehow proportional) to the width of the whole window. So when the main nav bar is expanded (the default) the field data panel is a bit narrower and was causing a test to fail. I drastically reduced the expected size from
> 180to> 20in these tests to match the collapsed test which checks< 20.Another side-affect of the change in widths was the 2 of the visualize tests were failing.
Area Chart was failing to get the expected 4 timestamps in the X-Axis legend. Only 3 were shown because the chart width was slightly smaller. I increased the width using setWindowSize in all the visualize tests from 1200 to 1280 (in the index.js) to fix it. Also could have collapsed the side nav but don't have a method for that new feature yet.
Tile Map was also failing but is also fixed by the increase in window width.
Finally, while testing these changes, I added a call to getSpinnerDone in a couple of the discover_page methods to eliminate a bunch of tryForTime failures. We might be able to remove a few sleeps now too but I can't easily test those changes on Jenkins so I left them in.