Port of appStatus from 4.x branch #8148
Conversation
|
This needs to be rebased or have master merged |
|
|
| } | ||
|
|
||
| function getStatus() { | ||
| const currentState = removeIgnoredProps(cloneDeep(state.toJSON())); |
There was a problem hiding this comment.
Can you add this above this line: // state.toJSON returns a reference, clone so we can mutate it safely
|
2 very tiny changes, then this LGTM! |
|
@cjcenizal you mind taking a quick look at this too, since you reviewed the original one? This is likely going to be the code you are going to be using with the app state changes I think. |
| app | ||
| .directive('discoverApp', function () { | ||
| return { | ||
| controllerAs: 'discoverApp', |
There was a problem hiding this comment.
Minor suggestion: if we add restrict: 'E', then we can make the markup a bit cleaner (below).
|
Just a couple small suggestions, and then this LGTM too! |
|
@w33ble, @cjcenizal I applied the changes you both suggested. |
| app.controller('discover', function ($scope, config, courier, $route, $window, Notifier, | ||
| app.directive('discoverApp', function () { | ||
| return { | ||
| controllerAs: 'discoverApp', |
There was a problem hiding this comment.
Don't forget to add restrict: 'E' here
| .controller('VisEditor', function ($scope, $route, timefilter, AppState, $location, kbnUrl, $timeout, courier, Private, Promise) { | ||
| .directive('visualizeApp', function () { | ||
| return { | ||
| controllerAs: 'visualizeApp', |
There was a problem hiding this comment.
Needs restrict: 'E' here too
…iscover, visualize
|
LGTM! |
Port of appStatus from 4.x branch Former-commit-id: 0b472a3
…tity flyouts (#174438) This PR adds the Asset Criticality selector to both the new User and Host expandable flyouts User flyout: <img width="770" alt="Screenshot 2024-01-08 at 12 17 57" src="https://github.com/elastic/kibana/assets/2423976/6c07de00-4863-47ed-83f5-67aec6354585"> Host flyout: <img width="749" alt="Screenshot 2024-01-08 at 12 18 09" src="https://github.com/elastic/kibana/assets/2423976/815ed517-954b-4ab5-9ccf-5f4ca28ec5c2"> Part of [#8148](elastic/security-team#8148) and the parent epic [#4208](elastic/security-team#4208) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…tity flyouts (elastic#174438) This PR adds the Asset Criticality selector to both the new User and Host expandable flyouts User flyout: <img width="770" alt="Screenshot 2024-01-08 at 12 17 57" src="https://github.com/elastic/kibana/assets/2423976/6c07de00-4863-47ed-83f5-67aec6354585"> Host flyout: <img width="749" alt="Screenshot 2024-01-08 at 12 18 09" src="https://github.com/elastic/kibana/assets/2423976/815ed517-954b-4ab5-9ccf-5f4ca28ec5c2"> Part of [elastic#8148](elastic/security-team#8148) and the parent epic [elastic#4208](elastic/security-team#4208) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Closes #8068
Adds the appStatus introduced in #7984 to discover, dashboard, and visualize apps
Applies the cloneDeep fix from #8066 to state_manager
Applies changes to state_monitor_factory from #8082
Changes the root node type of dashboard from:
<div dashboard-app ...>->'<dashboard-app ...>Changes the root node type of discover from:
<div ng-controller="discover" ...>->'<discover-app ...>Changes the root node type of visualization editor from:
<div ng-controller="VisEditor" ...>->'<visualize-app ...>