Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [App Search] Credentials: Add final Logic and server routes (#81519) #81540

Merged
merged 2 commits into from
Oct 26, 2020

Conversation

cee-chen
Copy link
Contributor

Backports the following commits to 7.x:

…81519)

* Add fullEngineAccessChecked logic

* Add onEngineSelect logic

* [Refactor] DRY out/simplify http mocks

Note: import reorder is required in for mocks to work correctly

* Add onApiTokenChange logic

* Update flyout footer to use onApiTokenChange

* Add new POST/PUT server routes

+ some opinionated comments

* [PR feedback] tests copy, extra data tests

* [PR feedback] Reuse fullEngineAccessChecked, fix fullEngineAccessChecked being undefined vs a bool
@cee-chen cee-chen force-pushed the backport/7.x/pr-81519 branch from 9d37cea to e18bb7b Compare October 26, 2020 19:21
@cee-chen
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
enterpriseSearch 656.9KB 659.2KB +2.3KB

History

  • 💚 Build #83482 succeeded 9d37cea6ac49d8146c9c594258ebe09150f8e963

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen merged commit 9385b49 into elastic:7.x Oct 26, 2020
@cee-chen cee-chen deleted the backport/7.x/pr-81519 branch October 26, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants