[ML] Fix partition value selection on the Single Metric Viewer #81585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
:ml
v8.0.0
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
This was referenced Oct 26, 2020
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Oct 26, 2020
…ic#81585) * [ML] remove tooltip wrapper for partition value control * [ML] add spacer
darnautov
added a commit
that referenced
this pull request
Oct 26, 2020
… (#81599) * [ML] remove tooltip wrapper for partition value control * [ML] add spacer
darnautov
added a commit
that referenced
this pull request
Oct 26, 2020
… (#81600) * [ML] remove tooltip wrapper for partition value control * [ML] add spacer
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 26, 2020
…arm-phase-to-formlib * 'master' of github.com:elastic/kibana: [Trigger Actions UI] Properly unmount app (elastic#81436) skip flaky suite (elastic#81576) skip flaky suite (elastic#78373) [Security Solution] Fix styling of EditDataProvider content (elastic#81456) [Search] Error Alignment 2 (elastic#80965) [APM] Unskip test (elastic#81574) [ML] Fix partition value selection on the Single Metric Viewer (elastic#81585) cleaning up expression service types (elastic#80643) Fix suggestions dropdown for query input (elastic#80990) [Usage collection] Make `schema` mandatory (elastic#79999) [ILM] Update show/hide data tier logic on cloud (elastic#81455) added brace import to advanced settings (elastic#81458) chore(NA): add spec-to-console and plugin-helpers as devOnly dependencies
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Because of the recent EUI upgrade, the selection of partition values from the dropdown wasn't possible, in particular, the tooltip component was resetting virtualized list scrolling. The easiest solution is to remove a tooltip wrapper, assuming a warning callout on top and helper text below the control suffice.
Also fixed margins for the callout.
Note:
Before:
After:
Checklist