Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook hasAuth Migrations #81764

Closed
wants to merge 1 commit into from

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Oct 27, 2020

Summary

Fixing failing test from #81390

Needed to update the migration to run on webhook action types after the changes from #81673. I should have merged from upstream after the PR was merged but I forgot 👎

@ymao1 ymao1 added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.11.0 labels Oct 27, 2020
@ymao1 ymao1 requested a review from a team as a code owner October 27, 2020 12:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green CI 👍

@ymao1
Copy link
Contributor Author

ymao1 commented Oct 27, 2020

Closing this PR because I ended up reverting the merge commit and will redo the original PR

@ymao1 ymao1 closed this Oct 27, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ymao1 ymao1 deleted the alerting/webhook-secrets-test branch February 4, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants