Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Send to background UI #81793

Merged
merged 17 commits into from
Nov 16, 2020
Merged

[Search] Send to background UI #81793

merged 17 commits into from
Nov 16, 2020

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Oct 27, 2020

Summary

Closes: #81004

This is just a component and not a connected to a service.

You can see all states in the storybook:

Screenshot 2020-11-09 at 14 36 23

yarn storybook data_enhanced

Or see it appear in Kibana setting config in your kibana.dev.yml

Screenshot 2020-11-09 at 18 00 12

xpack.data_enhanced.search.sendToBackground.enabled: true

It will appear only for apps that integrate with session service (discover and dashboard) for now.
You can open the popover, but can't do anything with it yet.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@Dosant Dosant added Feature:Search Querying infrastructure in Kibana v8.0.0 Team:AppArch release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Oct 27, 2020
Copy link
Contributor Author

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elastic/kibana-platform, in scope of this feature I need to add a new extension point for chrome. Could you please take a look and give feedback on platform changes 🙏
We can start a discussion here with feature context and later I'd extract it into separate pr.

src/core/public/chrome/chrome_service.tsx Outdated Show resolved Hide resolved
x-pack/plugins/data_enhanced/public/plugin.ts Outdated Show resolved Hide resolved
@Dosant Dosant changed the title [wip] Send to background UI [Search] Send to background UI Nov 10, 2020
@Dosant Dosant marked this pull request as ready for review November 10, 2020 12:35
@Dosant Dosant requested review from a team as code owners November 10, 2020 12:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@Dosant Dosant requested review from lukasolson and lizozom November 10, 2020 12:36
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Operations: Storybook addition LGTM

Copy link
Contributor

@mdefazio mdefazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design updates are good. Thanks!

Copy link
Member

@lukasolson lukasolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a couple of minor notes below.

src/plugins/data/common/search/session/mocks.ts Outdated Show resolved Hide resolved
x-pack/plugins/data_enhanced/public/plugin.ts Outdated Show resolved Hide resolved
@Dosant
Copy link
Contributor Author

Dosant commented Nov 16, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dataEnhanced 19 39 +20

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataEnhanced 0.0B 26.3KB +26.3KB

Distributable file count

id before after diff
default 42828 42833 +5

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataEnhanced 28.3KB 34.7KB +6.4KB
Unknown metric groups

async chunk count

id before after diff
dataEnhanced 0 1 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant merged commit f60abf3 into elastic:master Nov 16, 2020
Dosant added a commit to Dosant/kibana that referenced this pull request Nov 16, 2020
Also adds xpack.data_enhanced.search.sendToBackground.enabled config option
Dosant added a commit that referenced this pull request Nov 16, 2020
Also adds xpack.data_enhanced.search.sendToBackground.enabled config option
phillipb added a commit to phillipb/kibana that referenced this pull request Nov 16, 2020
… into add-logs-to-node-details

* 'add-logs-to-node-details' of github.com:phillipb/kibana:
  fix tall vislib charts in visualize (elastic#83340)
  [Lens] Avoid unnecessary data fetching on dimension flyout open (elastic#82957)
  [Security Solution][Case] Change case connector minimum required license to basic (elastic#83401)
  fix logstash central pipeline management test  (elastic#83281)
  [Search] Send to background UI (elastic#81793)
  Migrate `/translations` route to core (elastic#83280)
  [APM] Ensure APM jest script can run (elastic#83398)
  [Uptime] Monitor status alert use url as instance (elastic#81736)
  [ML] Add basic license test run details to ML+Transform READMEs (elastic#83259)
  TSVB doesn't communicate it's index-patterns to dashboard (elastic#82964)
  [Alerting UI] Added ability to assign alert actions to resolved action group in UI (elastic#83139)
  Skips Vega test
  skip flaky suite (elastic#79967)
  [bundle optimization] Update to semver 7.x to get tree-shaking (elastic#83020)
  Added ability to fire actions when an alert instance is resolved (elastic#82799)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Search] Send to background UI
8 participants