Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump xml-crypto from 1.4.0 to 2.0.0 #81859

Merged
merged 3 commits into from
Oct 29, 2020

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 27, 2020

Bumps xml-crypto from 1.4.0 to 2.0.0.

Release notes

Sourced from xml-crypto's releases.

Disable HMAC by default

Due to the potential of a key confusion vulnerability in support of HMAC-SHA1, the HMAC-SHA1 "signing" algorithm has been disabled by default.

Previously, in certain situations it was possible to bypass signing checks by maliciously changing the algorithm to HMAC-SHA1 and using the public key as the HMAC secret.

If you need to validate an HMAC signature, you now must first call SignedXml.enableHMAC().

All users are encouraged to upgrade.

v1.5.3

Round out having callbacks for more methods (#209)

v1.5.2

Lock ejs to 2.6.1 without npm-shrinkwrap (638ab6c)

v1.5.1

Prevent global leak, pass xml object to callback (#207)

v1.5.0

Allow signature signing/verification to take place via callback (#206)

v1.4.1

validation instruction typo (#192) update js-yaml (#205) correct whitespace normalization (#196)

Commits
  • 3d9db71 [SECURITY] Disable HMAC sig methods by default due to key confusion
  • d295ecc 1.5.3
  • 79fc2ac Merge pull request #209 from troyfactor4/master
  • f982b0c return response as well even if async
  • 4ffe0aa Async response for built in algo sign/verify
  • 713f3d8 1.5.2
  • 638ab6c Lock ejs to 2.6.1
  • 2730604 1.5.1
  • 07e2320 Merge pull request #207 from troyfactor4/master
  • 234bc0b enable more use cases by returning the xml object in callback
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by bawolff, a new releaser for xml-crypto since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [xml-crypto](https://github.com/yaronn/xml-crypto) from 1.4.0 to 2.0.0.
- [Release notes](https://github.com/yaronn/xml-crypto/releases)
- [Commits](node-saml/xml-crypto@v1.4.0...v2.0.0)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 27, 2020
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@kibanamachine kibanamachine added 💝community and removed dependencies Pull requests that update a dependency file labels Oct 27, 2020
@legrego
Copy link
Member

legrego commented Oct 28, 2020

Jenkins, test this

@legrego legrego added release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0 labels Oct 28, 2020
@legrego
Copy link
Member

legrego commented Oct 28, 2020

@elasticmachine merge upstream

@legrego
Copy link
Member

legrego commented Oct 29, 2020

@elasticmachine merge upstream

@legrego
Copy link
Member

legrego commented Oct 29, 2020

Jenkins, test this

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@legrego legrego merged commit 5752b7a into master Oct 29, 2020
@legrego legrego deleted the dependabot/npm_and_yarn/xml-crypto-2.0.0 branch October 29, 2020 18:21
legrego added a commit that referenced this pull request Oct 29, 2020
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💝community release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants