Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: add log statement when deleting transform #81927

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Chore: add log statement when deleting transform #81927

merged 1 commit into from
Oct 28, 2020

Conversation

nnamdifrankie
Copy link
Contributor

@nnamdifrankie nnamdifrankie commented Oct 28, 2020 •
edited
Loading

Summary

  • add more logs to the transform deletions.
  • the image below comes from the siem server and we want to see the state of the installation reference as well as how many times the installation is restarted. We have tested in cloud instance and have not been able to reproduce this.

image

Checklist

Delete any items that are not applicable to this PR.

@nnamdifrankie nnamdifrankie requested a review from a team October 28, 2020 17:33
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Oct 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@nnamdifrankie nnamdifrankie added release_note:skip Skip the PR/issue when compiling release notes v7.11 v8.0.0 labels Oct 28, 2020
@nnamdifrankie
Copy link
Contributor Author

@jfsiii Please review just added logs so we see how things are deleted, I think we will leave these in for now.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nnamdifrankie nnamdifrankie merged commit f88c664 into elastic:master Oct 28, 2020
@nnamdifrankie nnamdifrankie deleted the Chore-add-logging-for-current-ref-transform branch October 28, 2020 19:36
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 30, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 81927 or prevent reminders by adding the backport:skip label.

@nnamdifrankie nnamdifrankie mentioned this pull request Oct 30, 2020
Merged
nnamdifrankie added a commit to nnamdifrankie/kibana that referenced this pull request Oct 30, 2020
@nnamdifrankie
[Fleet]: add log statement when deleting transform (elastic#81927)
c7b3923 
[Fleet]: add log statement when deleting transform
# Conflicts:
#	x-pack/plugins/ingest_manager/server/services/epm/elasticsearch/transform/remove.ts
nnamdifrankie added a commit that referenced this pull request Nov 2, 2020
@nnamdifrankie
[7.x] [Fleet]: add log statement when deleting transform (#81927) (#8…
e3a6500 
…2190)

[Fleet]: add log statement when deleting transform (#81927)
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfsiii jfsiii jfsiii approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nnamdifrankie @elasticmachine @kibanamachine @jfsiii