Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GS] Fix onChange error when submitting with no selected item(s) #82252

Merged
merged 1 commit into from
Nov 2, 2020
Merged

[GS] Fix onChange error when submitting with no selected item(s) #82252

merged 1 commit into from
Nov 2, 2020

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Nov 2, 2020 •
edited by myasonik
Loading

Summary

Fix #82222 and fix #80005 + add additional fireproof, like, just in case.

@pgayvallet pgayvallet requested a review from a team November 2, 2020 10:54
@pgayvallet pgayvallet added release_note:skip Skip the PR/issue when compiling release notes v7.10.1 v7.11.0 v8.0.0 labels Nov 2, 2020
@pgayvallet pgayvallet mentioned this pull request Nov 2, 2020
Closed
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

page load bundle size

id before after diff
globalSearchBar 28.3KB 28.5KB +197.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@myasonik
Copy link
Contributor

myasonik commented Nov 2, 2020

Also closes #80005

@pgayvallet pgayvallet merged commit fb629bd into elastic:master Nov 2, 2020
pgayvallet added a commit to pgayvallet/kibana that referenced this pull request Nov 2, 2020
@pgayvallet
Fireproof onChange (elastic#82252)
69ea13f
This was referenced Nov 2, 2020
Merged
Merged
pgayvallet added a commit to pgayvallet/kibana that referenced this pull request Nov 2, 2020
@pgayvallet
Fireproof onChange (elastic#82252)
5e8348f
pgayvallet added a commit that referenced this pull request Nov 2, 2020
@pgayvallet
Fireproof onChange (#82252) (#82289)
9cd1135
pgayvallet added a commit that referenced this pull request Nov 2, 2020
@pgayvallet
Fireproof onChange (#82252) (#82290)
c95a26b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myasonik myasonik myasonik approved these changes

@ryankeairns ryankeairns ryankeairns approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.10.1 v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Global search does not work Make nav search more safe
4 participants
@pgayvallet @kibanamachine @myasonik @ryankeairns