Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Fix underlying data drilldown for Lens #82737

Merged

Conversation

flash1293
Copy link
Contributor

Fixes #82657

This PR makes sure there are no duplicates in the index pattern in the Lens embeddable output. This broke the "Explore underlying data" drilldown on dashboard because this feature only works for a single index pattern per embeddable.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
lens 1.0MB 1.0MB +53.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review November 6, 2020 07:51
@flash1293 flash1293 requested a review from a team November 6, 2020 07:51
@flash1293 flash1293 added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Nov 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for adding a functional test too!
Tested by adding to a 'flights' dashboard:

  • a 'flights' index pattern vis (works)
  • an 'ecommerce' index pattern vis (works)
  • a mixed (flights and ecommerce) vis (doesn't work, as expected)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Drilldowns to discover are not shown in dashboard
4 participants