[Discover] Unskip date_nanos and shard links functional tests

src/plugins/data/common/index_patterns/index_patterns/index_patterns.ts

@@ -200,7 +200,7 @@ export class IndexPatternsService {
       return true;
     }
 
-    return Object.values(specs).every((spec) => {
+    const isFieldRefreshRequired = Object.values(specs).every((spec) => {
       // See https://github.com/elastic/kibana/pull/8421
       const hasFieldCaps = 'aggregatable' in spec && 'searchable' in spec;
 
@@ -209,6 +209,7 @@ export class IndexPatternsService {
 
       return !hasFieldCaps || !hasDocValuesFlag;
     });
+    return isFieldRefreshRequired;
   }
 
   /**
@@ -217,12 +218,13 @@ export class IndexPatternsService {
    */
   getFieldsForWildcard = async (options: GetFieldsOptions = {}) => {
     const metaFields = await this.config.get(UI_SETTINGS.META_FIELDS);
-    return this.apiClient.getFieldsForWildcard({
+    const result = this.apiClient.getFieldsForWildcard({
       pattern: options.pattern,
       metaFields,
       type: options.type,
       params: options.params || {},
     });
+    return result;
   };
 
   /**
@@ -276,22 +278,28 @@ export class IndexPatternsService {
     title: string,
     options: GetFieldsOptions
   ) => {
+    // eslint-disable-next-line no-console
+    console.log('refreshFieldSpecMap start');
     const scriptdFields = Object.values(fields).filter((field) => field.scripted);
     try {
       const newFields = await this.getFieldsForWildcard(options);
       return this.fieldArrayToMap([...newFields, ...scriptdFields]);
     } catch (err) {
+      // eslint-disable-next-line no-console
+      console.log('refreshFieldSpecMap ERROR');
       if (err instanceof IndexPatternMissingIndices) {
         this.onNotification({ title: (err as any).message, color: 'danger', iconType: 'alert' });
         return {};
       }
+      const msg = i18n.translate('data.indexPatterns.fetchFieldErrorTitle', {
+        defaultMessage: 'Error fetching fields for index pattern {title} (ID: {id})',
+        values: { id, title },
+      });
 
       this.onError(err, {
-        title: i18n.translate('data.indexPatterns.fetchFieldErrorTitle', {
-          defaultMessage: 'Error fetching fields for index pattern {title} (ID: {id})',
-          values: { id, title },
-        }),
+        title: msg,
       });
+      throw new Error(msg);
     }
     return fields;
   };
@@ -389,6 +397,8 @@ export class IndexPatternsService {
           iconType: 'alert',
         });
       } else {
+        // eslint-disable-next-line no-console
+        console.error('fields fetching not possible');
         this.onError(err, {
           title: i18n.translate('data.indexPatterns.fetchFieldErrorTitle', {
             defaultMessage: 'Error fetching fields for index pattern {title} (ID: {id})',
@@ -420,7 +430,6 @@ export class IndexPatternsService {
         });
       }
     }
-
     indexPattern.resetOriginalSavedObjectBody();
     return indexPattern;
   };
@@ -517,6 +526,8 @@ export class IndexPatternsService {
       .then((resp) => {
         indexPattern.id = resp.id;
         indexPattern.version = resp.version;
+        // eslint-disable-next-line no-console
+        console.error('index pattern saved successfully');
       })
       .catch(async (err) => {
         if (err?.res?.status === 409 && saveAttempts++ < MAX_ATTEMPTS_TO_RESOLVE_CONFLICTS) {

src/plugins/data/public/index_patterns/index_patterns/index_patterns_api_client.ts

@@ -36,6 +36,11 @@ export class IndexPatternsApiClient implements IIndexPatternsApiClient {
         query,
       })
       .catch((resp: any) => {
+        // eslint-disable-next-line no-console
+        console.error('IndexPatternsApiClient ERROR');
+        // eslint-disable-next-line no-console
+        console.error('IndexPatternsApiClient ERROR DEBUG', JSON.stringify(resp));
+
         if (resp.body.statusCode === 404 && resp.body.attributes?.code === 'no_matching_indices') {
           throw new IndexPatternMissingIndices(resp.body.message);
         }
@@ -80,7 +85,23 @@ export class IndexPatternsApiClient implements IIndexPatternsApiClient {
         meta_fields: metaFields,
       };
     }
+    // eslint-disable-next-line no-console
+    console.log('API client url', url);
+    // eslint-disable-next-line no-console
+    console.log('API client query', JSON.stringify(query));
 
-    return this._request(url, query).then((resp: any) => resp.fields);
+    return this._request(url, query)
+      .then((resp: any) => {
+        // eslint-disable-next-line no-console
+        console.log('API client url response', JSON.stringify(resp));
+        return resp.fields;
+      })
+      .catch((e) => {
+        // eslint-disable-next-line no-console
+        console.error('API client Error Message', e.message);
+        // eslint-disable-next-line no-console
+        console.error('API client Error', JSON.stringify(e));
+        throw new Error('API client ERROR');
+      });
   }
 }

test/functional/apps/discover/_date_nanos.js

@@ -28,7 +28,8 @@ export default function ({ getService, getPageObjects }) {
   const toTime = 'Sep 23, 2019 @ 03:31:44.000';
 
   // Failing: See https://github.com/elastic/kibana/issues/82035
-  describe.skip('date_nanos', function () {
+
+  describe('date_nanos', function () {
     before(async function () {
       await esArchiver.loadIfNeeded('date_nanos');
       await kibanaServer.uiSettings.replace({ defaultIndex: 'date-nanos' });

test/functional/apps/discover/_discover.js

@@ -304,10 +304,14 @@ export default function ({ getService, getPageObjects }) {
 
         const getRequestTimestamp = async () => {
           const requestStats = await inspector.getTableData();
-          const requestTimestamp = requestStats.filter((r) =>
-            r[0].includes('Request timestamp')
-          )[0][1];
-          return requestTimestamp;
+          const requestStatsRow = requestStats.filter(
+            (r) => r && r[0] && r[0].includes('Request timestamp')
+          );
+          if (!requestStatsRow || !requestStatsRow[0] || !requestStatsRow[0][1]) {
+            return '';
+          }
+
+          return requestStatsRow[0][1];
         };
 
         const requestTimestampBefore = await getRequestTimestamp();
@@ -316,7 +320,7 @@ export default function ({ getService, getPageObjects }) {
           log.debug(
             `Timestamp before: ${requestTimestampBefore}, Timestamp after: ${requestTimestampAfter}`
           );
-          return requestTimestampBefore !== requestTimestampAfter;
+          return requestTimestampAfter && requestTimestampBefore !== requestTimestampAfter;
         });
       });
 

test/functional/apps/discover/_doc_navigation.js

@@ -28,13 +28,11 @@ export default function ({ getService, getPageObjects }) {
   const esArchiver = getService('esArchiver');
   const retry = getService('retry');
 
-  // FLAKY: https://github.com/elastic/kibana/issues/78373
-  describe.skip('doc link in discover', function contextSize() {
+  describe('doc link in discover', function contextSize() {
     beforeEach(async function () {
       log.debug('load kibana index with default index pattern');
-      await esArchiver.loadIfNeeded('discover');
-
       await esArchiver.loadIfNeeded('logstash_functional');
+      await esArchiver.loadIfNeeded('discover');
       await PageObjects.common.navigateToApp('discover');
       await PageObjects.timePicker.setDefaultAbsoluteRange();
       await PageObjects.discover.waitForDocTableLoadingComplete();

test/functional/apps/discover/_field_data.js

@@ -27,8 +27,7 @@ export default function ({ getService, getPageObjects }) {
   const queryBar = getService('queryBar');
   const PageObjects = getPageObjects(['common', 'header', 'discover', 'visualize', 'timePicker']);
 
-  // FLAKY: https://github.com/elastic/kibana/issues/78689
-  describe.skip('discover tab', function describeIndexTests() {
+  describe('discover tab', function describeIndexTests() {
     this.tags('includeFirefox');
     before(async function () {
       await esArchiver.loadIfNeeded('logstash_functional');

test/functional/apps/discover/_inspector.js

@@ -34,8 +34,7 @@ export default function ({ getService, getPageObjects }) {
     return hitsCountStatsRow[STATS_ROW_VALUE_INDEX];
   }
 
-  // FLAKY: https://github.com/elastic/kibana/issues/39842
-  describe.skip('inspect', () => {
+  describe('inspect', () => {
     before(async () => {
       await esArchiver.loadIfNeeded('logstash_functional');
       await esArchiver.load('discover');

test/functional/apps/discover/_shared_links.js

@@ -28,8 +28,7 @@ export default function ({ getService, getPageObjects }) {
   const browser = getService('browser');
   const toasts = getService('toasts');
 
-  // FLAKY: https://github.com/elastic/kibana/issues/80104
-  describe.skip('shared links', function describeIndexTests() {
+  describe('shared links', function describeIndexTests() {
     let baseUrl;
 
     async function setup({ storeStateInSessionStorage }) {