Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Manager] Move single use function into getRegistryPackage #82885

Merged
merged 2 commits into from
Nov 6, 2020
Merged

[Ingest Manager] Move single use function into getRegistryPackage #82885

merged 2 commits into from
Nov 6, 2020

Conversation

jfsiii
Copy link
Contributor

@jfsiii jfsiii commented Nov 6, 2020

Summary

  • Function rename to follow existing get/fetch convention 
    - export async function loadRegistryPackage(
+ export async function getRegistryPackage(
  • Moved unpackRegistryPackageToCache into getRegistryPackage
    • In my opinion, those three/four statements are more clear than the previous name
    • It isn't used anywhere else

@jfsiii jfsiii requested a review from a team November 6, 2020 20:05
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@jfsiii jfsiii self-assigned this Nov 6, 2020
@jfsiii jfsiii requested review from skh and neptunian November 6, 2020 20:06
@jfsiii jfsiii added release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0 labels Nov 6, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jfsiii jfsiii merged commit e8ec392 into elastic:master Nov 6, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 9, 2020
@gmmorris
Merge branch 'master' into actions/license-allowlist
26faa76 
* master: (68 commits)
  [Fleet] Make stream id unique in agent policy (elastic#82447)
  skip flaky suite (elastic#82915)
  skip flaky suite (elastic#75794)
  Copy `dateAsStringRt` to observability plugin (elastic#82839)
  [Maps] rename connected_components/map folder to mb_map (elastic#82897)
  [Security Solution] Fix EventsViewer DnD cypress tests (elastic#82619)
  [Security Solution] Adds logging and performance fan out API for threat/Indicator matching (elastic#82546)
  Implemented Alerting health status pusher by using task manager and status pooler for Kibana status plugins 'kibanahost/api/status' (elastic#79056)
  [APM] Adds new configuration 'xpack.apm.maxServiceEnvironments' (elastic#82090)
  Move single use function in line (elastic#82885)
  [ML] Add unsigned_long support to data frame analytics and anomaly detection (elastic#82636)
  Add flot_chart dependency from shared_deps to Shareable Runtime (elastic#81649)
  [Security Solution][Detections] - Auto refresh all rules/monitoring tables (elastic#82062)
  [APM] Fix apm e2e runner script commands (elastic#82798)
  [Ingest Manager] Move cache functions to from registry to archive (elastic#82871)
  Update webpack-dev-server and webpack-cli (elastic#82844)
  [Uptime] Migrate to new es client (elastic#82003)
  Move parseAndVerify* functions to validation.ts (elastic#82845)
  Remove yeoman & yo (elastic#82825)
  [Canvas] Fix elements not being updated properly when filter is changed on workpad (elastic#81863)
  ...
@jfsiii jfsiii mentioned this pull request Nov 9, 2020
Merged
phillipb added a commit to phillipb/kibana that referenced this pull request Nov 10, 2020
@phillipb
Merge branch 'master' of github.com:elastic/kibana into bootstrap-nod…
864b5bd 
…e-details-overlay

* 'master' of github.com:elastic/kibana: (201 commits)
  Added `defaultActionMessage` to index threshold alert UI type definition (elastic#80936)
  [ILM] Migrate Delete phase and name field to Form Lib (elastic#82834)
  skip flaky suite (elastic#57426)
  [Alerting] adds an Run When field in the alert flyout to assign the action to an Action Group (elastic#82472)
  [APM] Expose APM event client as part of plugin contract (elastic#82724)
  [Logs UI] Fix errors during navigation (elastic#78319)
  Enable send to background in TSVB (elastic#82835)
  SavedObjects search_dsl: add match_phrase_prefix clauses when using prefix search (elastic#82693)
  [Ingest Manager] Unify install* under installPackage (elastic#82916)
  [Fleet] Make stream id unique in agent policy (elastic#82447)
  skip flaky suite (elastic#82915)
  skip flaky suite (elastic#75794)
  Copy `dateAsStringRt` to observability plugin (elastic#82839)
  [Maps] rename connected_components/map folder to mb_map (elastic#82897)
  [Security Solution] Fix EventsViewer DnD cypress tests (elastic#82619)
  [Security Solution] Adds logging and performance fan out API for threat/Indicator matching (elastic#82546)
  Implemented Alerting health status pusher by using task manager and status pooler for Kibana status plugins 'kibanahost/api/status' (elastic#79056)
  [APM] Adds new configuration 'xpack.apm.maxServiceEnvironments' (elastic#82090)
  Move single use function in line (elastic#82885)
  [ML] Add unsigned_long support to data frame analytics and anomaly detection (elastic#82636)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 10, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

jfsiii pushed a commit to jfsiii/kibana that referenced this pull request Nov 10, 2020
Move single use function in line (elastic#82885)
e451004 
## Summary

 * Function rename to follow existing get/fetch convention
    ```diff
    - export async function loadRegistryPackage(
    + export async function getRegistryPackage(
    ```
 * Moved `unpackRegistryPackageToCache` into `getRegistryPackage`
    * In my opinion, those three/four statements are more clear than the previous name
    * It isn't used anywhere else
jfsiii pushed a commit that referenced this pull request Nov 11, 2020
Move single use function in line (#82885) (#82997)
389d744 
## Summary

 * Function rename to follow existing get/fetch convention
    ```diff
    - export async function loadRegistryPackage(
    + export async function getRegistryPackage(
    ```
 * Moved `unpackRegistryPackageToCache` into `getRegistryPackage`
    * In my opinion, those three/four statements are more clear than the previous name
    * It isn't used anywhere else
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skh skh skh approved these changes

@neptunian neptunian Awaiting requested review from neptunian

Assignees

@jfsiii jfsiii

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jfsiii @elasticmachine @kibanamachine @skh