Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Endpoint][Admin] Malware user notification is a platinum tiered feature #82894

Merged
merged 12 commits into from
Nov 18, 2020
Merged

[Security Solution][Endpoint][Admin] Malware user notification is a platinum tiered feature #82894

merged 12 commits into from
Nov 18, 2020

Conversation

parkiino
Copy link
Contributor

@parkiino parkiino commented Nov 6, 2020 •
edited
Loading

Summary

  • Malware user notification + custom message is only visible when license is platinum+
  • Unit tests
  • Updates security solution plugin (server and public) to use Licensing Start contract as opposed to deprecated Setup contract
  • Adds useLicense hook

@parkiino parkiino changed the title license setup in the plugin [Security Solution][Endpoint][Admin] Malware user notification and custom message is a platinum tiered feature Nov 12, 2020
@parkiino parkiino changed the title [Security Solution][Endpoint][Admin] Malware user notification and custom message is a platinum tiered feature [Security Solution][Endpoint][Admin] Malware user notification is a platinum tiered feature Nov 12, 2020
@parkiino parkiino added Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.11.0 v8.0.0 labels Nov 12, 2020
@parkiino parkiino marked this pull request as ready for review November 12, 2020 23:20
@parkiino parkiino requested review from a team as code owners November 12, 2020 23:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

@apmmachine
Copy link
Contributor

💚 Build Succeeded

@kevinlog kevinlog requested review from kevinlog and a team and removed request for a team and kevinlog November 16, 2020 18:37
paul-tavares
paul-tavares reviewed Nov 16, 2020
View reviewed changes
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would like comment on my question

x-pack/plugins/security_solution/public/plugin.tsx
@@ -59,7 +59,7 @@ import {
IndexFieldsStrategyResponse,
} from '../common/search_strategy/index_fields';
import { SecurityAppStore } from './common/store/store';
import { getCaseConnectorUI } from './common/lib/connectors';
import { licenseService } from './common/hooks/use_license';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to impact the Cases? I see that line 315 was also removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no i did not. i got a typecheck error and i wasn't sure if it was a failed merge from master. i'm going to add it back in because this was probs a mistake on my end

paul-tavares
paul-tavares approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2075 2077 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.9MB 7.9MB +258.0B

Distributable file count

id before after diff
default 42836 42838 +2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 165.0KB 167.6KB +2.6KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@parkiino parkiino merged commit 69e3ceb into elastic:master Nov 18, 2020
@parkiino parkiino deleted the task/license-tier-malware branch November 18, 2020 14:58
@parkiino parkiino mentioned this pull request Nov 18, 2020
Merged
phillipb added a commit to phillipb/kibana that referenced this pull request Nov 18, 2020
@phillipb
Merge branch 'master' of github.com:elastic/kibana into add-metrics-t…
57f19f3 
…o-node-details

* 'master' of github.com:elastic/kibana:
  [Security Solution][Endpoint][Admin] Malware user notification is a platinum tiered feature (elastic#82894)
parkiino added a commit that referenced this pull request Nov 18, 2020
@parkiino
[Security Solution][Endpoint][Admin] Malware user notification is a p…
5c7421c 
…latinum tiered feature (#82894) (#83643)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-tavares paul-tavares paul-tavares approved these changes

@kevinlog kevinlog kevinlog approved these changes

Assignees
No one assigned
Labels
Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@parkiino @elasticmachine @apmmachine @kibanamachine @kevinlog @paul-tavares