-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alerting] Moves the Index & Geo Threshold UIs into the Stack Alerts Public Plugin #82951
Changes from 16 commits
188ddd8
d6459b1
e02056e
c7ae42d
56b286d
aadbe35
f3ca392
b6df73b
72f0816
b94d2c3
a8d1a8f
0e3a745
a7f37a9
2f616f1
0104cb6
839463f
845f359
90bcf6d
9e2beac
84ecfdb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -102,3 +102,4 @@ pageLoadAssetSize: | |
visualizations: 295025 | ||
visualize: 57431 | ||
watcher: 43598 | ||
stackAlerts: 29684 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ | |
"server": true, | ||
"version": "8.0.0", | ||
"kibanaVersion": "kibana", | ||
"requiredPlugins": ["alerts", "features"], | ||
"requiredPlugins": ["alerts", "features", "triggersActionsUi", "kibanaReact"], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't have a case where someone would want to disable I could imagine a situation where we might someday want to build a UI-free version of Kibana to be able to run the alerts/actions without the UI, but that's super-long term, and no need to account for that yet, I don't think. Just wanted to make sure we didn't have any other use cases like that ... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For the time being we'll have to live with it as a dependency for actions or alerts 🤷 |
||
"configPath": ["xpack", "stack_alerts"], | ||
"ui": false | ||
"ui": true | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think using
defaultValue: false
means you don't need aschema.maybe()
wrapper. Or else I'm not sure what this could mean. When would thedefaultValue
be applied?This is always a bit of a confusing aspect to me with config-schema, and other type builders like this. :-) I'd prefer we use the "fewer possibilities" of what the value can be, when we can, and removing the
schema.maybe()
means that property should always have a boolean value vs boolean | undefined, which seems like will be easier for us anyway.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a fair point - I copied it as is from the original plugin.
Think you're right... I'll sort that out.