[Ingest Manager] Simplify createInstallation interface #83180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
jfsiii
added
release_note:skip
jfsiii
commented
Nov 11, 2020
| installSource, | ||
| }); | ||
| } else { | ||
| if (installedPkg) { |
There was a problem hiding this comment.
Swapped the condition to avoid the double-negative (!!installedPkg)
jfsiii
commented
Nov 11, 2020
Comment on lines
-386
to
+381
| return [...installedKibana, ...installedEs]; | ||
|
|
||
| return created; |
There was a problem hiding this comment.
If I understand the existing code correctly (both reading & running with logging), we always passed empty arrays for the two installed* params. Which makes this [ ...[], ...[] ] or []
Even if they had values, rather than return the caller data they gave, return the result of the function.
The return value isn't used by the one caller so this is safe and unnoticed.
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
skh
approved these changes
Nov 11, 2020
jfsiii
pushed a commit
to jfsiii/kibana
that referenced
this pull request
Nov 11, 2020
jfsiii
pushed a commit
that referenced
this pull request
Nov 11, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 12, 2020
…ts-public * upstream/master: (57 commits) Remove unused asciidoc file (elastic#83228) [Lens] Remove background from lens embeddable (elastic#83061) [Discover] Unskip flaky tests based on discover fixture index pattern (elastic#82991) Removing unnecessary trailing slash in CODEOWNERS Trying to fix CODEOWNERS again, where was a non-existent team prior (elastic#83236) Trying to fix CODEOWERS, missing a starting slash (elastic#83233) skip flaky suite (elastic#83231) Add enzyme rerender test helper (elastic#83208) Move Elasticsearch type definitions out of APM (elastic#83081) [ts/checkTsProjects] produce a more useful error message (elastic#83209) [kbnClient] retry updating config if necessary (elastic#83205) I accidentally removed this line in a recent PR (elastic#83201) Don't make the caller do work the function can do (elastic#83180) [App Search] Update EngineRouter & EngineNav to use EngineLogic (elastic#83138) [Workplace Search] Add routes for Sources (elastic#83125) Update logstash pipeline management to use system index APIs (elastic#80405) [ML] Replace EuiBasicTable with EuiInMemoryTable (elastic#83057) [Metrics UI] Add basic interaction and shell for node details overlay (elastic#82013) [App Search] Added the log retention confirmation modal to the Settings page (elastic#83009) [docs] Fix create map title in import geospatial page (elastic#83172) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
All internal changes.
createInstallationhas one caller (_installPackage) which doesn't use the return value.Push the work from the caller into the function. Replace empty/unused return value with something more helpful, if still unused.
Added comments next to code for more context