Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traffic chart #83721

Closed
wants to merge 20 commits into from
Closed

Traffic chart #83721

wants to merge 20 commits into from

Conversation

smith
Copy link
Contributor

@smith smith commented Nov 18, 2020 •
edited by sorenlouv
Loading

Add the throughput (traffic) chart to the overview page.

image

@smith smith added v7.11.0 release_note:skip Skip the PR/issue when compiling release notes labels Nov 18, 2020
smith
smith commented Nov 19, 2020
View reviewed changes
x-pack/plugins/apm/public/components/app/service_overview/service_overview_throughput_chart.tsx Outdated
const theme = useTheme();
const { serviceName } = useParams<{ serviceName?: string }>();
const { urlParams, uiFilters } = useUrlParams();
const transactionType = 'request';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard-coding this as "request" until changes from #83587 are merged.

@smith smith marked this pull request as ready for review November 19, 2020 19:11
@smith smith requested a review from a team as a code owner November 19, 2020 19:11
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Nov 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv
Copy link
Member

sorenlouv commented Nov 19, 2020 •
edited
Loading

Can you add a screenshot to the PR description please? 🙏

@cauemarcondes
Copy link
Contributor

@elasticmachine merge upstream

@elastic elastic deleted a comment from kibanamachine Nov 25, 2020
@sorenlouv
Copy link
Member

@elasticmachine merge upstream

@sorenlouv
Copy link
Member

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

cauemarcondes
cauemarcondes approved these changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just added some small comments

@sorenlouv @cauemarcondes
React.ComponentType<any>
24d1fd4 
Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 26, 2020 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1153 1155 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.1MB 3.1MB +14.8KB

Distributable file count

id before after diff
default 43011 43012 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv mentioned this pull request Nov 26, 2020
Merged
@sorenlouv sorenlouv closed this Nov 26, 2020
@sorenlouv
Copy link
Member

Replaced by #84439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv left review comments

@cauemarcondes cauemarcondes cauemarcondes approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smith @elasticmachine @sorenlouv @cauemarcondes @kibanamachine