Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix Anomaly Explorer population charts when multiple causes in anomaly #84254

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Nov 24, 2020

Summary

Fixes the anomaly charts in the Anomaly Explorer for anomalies in population detectors with by and over fields when there are multiple items in the anomaly record causes array.

Previously the charts for anomalies with multiples causes would render blank:
image

After:
image

This bug was introduced by #67569 as the calculation used to set the y axis domain would set the min and max to NaN as the actual and typical values are not present in the top level of the anomaly record used for the chart data for anomalies with more than one item in the causes array.

Checklist

Fixes #83676

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.2MB 5.2MB +25.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also did a local test to verify charts are populated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Anomaly Detection: Distribution Charts fail to load for complex detectors
4 participants