-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Fix Anomaly Explorer population charts when multiple causes in anomaly #84254
Merged
peteharverson
merged 1 commit into
elastic:master
from
peteharverson:ml-population-chart-fix
Nov 25, 2020
Merged
[ML] Fix Anomaly Explorer population charts when multiple causes in anomaly #84254
peteharverson
merged 1 commit into
elastic:master
from
peteharverson:ml-population-chart-fix
Nov 25, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
release_note:fix
:ml
Feature:Anomaly Detection
ML anomaly detection
v8.0.0
v7.11.0
v7.10.1
labels
Nov 24, 2020
Pinging @elastic/ml-ui (:ml) |
walterra
approved these changes
Nov 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, also did a local test to verify charts are populated.
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Nov 25, 2020
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Nov 25, 2020
This was referenced Nov 25, 2020
Merged
peteharverson
added a commit
that referenced
this pull request
Nov 25, 2020
peteharverson
added a commit
that referenced
this pull request
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the anomaly charts in the Anomaly Explorer for anomalies in population detectors with
by
andover
fields when there are multiple items in the anomaly recordcauses
array.Previously the charts for anomalies with multiples causes would render blank:
After:
This bug was introduced by #67569 as the calculation used to set the y axis domain would set the
min
andmax
toNaN
as theactual
andtypical
values are not present in the top level of the anomaly record used for the chart data for anomalies with more than one item in thecauses
array.Checklist
Fixes #83676