Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] mark legacy ES client methods deprecated #84358

Merged
merged 4 commits into from
Nov 30, 2020
Merged

[Core] mark legacy ES client methods deprecated #84358

merged 4 commits into from
Nov 30, 2020

Conversation

mshustov
Copy link
Contributor

Summary

  • mark the legacy client property exposed from RequestHandlerContext as deprecated as well

before:
2020-11-25_19-03-11
after:
2020-11-25_19-02-24
2020-11-25_19-04-18

@mshustov mshustov added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Nov 25, 2020
@mshustov mshustov requested a review from a team as a code owner November 25, 2020 18:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

timroes
timroes approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

pgayvallet
pgayvallet approved these changes Nov 30, 2020
View reviewed changes
src/core/server/index.ts Outdated
@@ -394,6 +394,7 @@ export interface RequestHandlerContext {
elasticsearch: {
client: IScopedClusterClient;
legacy: {
/* @deprecated Use {@link IScopedClusterClient}. */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo (tsdoc is probably not generated from this): /* -> /**

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov merged commit cb0a359 into elastic:master Nov 30, 2020
@mshustov mshustov deleted the mark-legacy-methods-depreacted branch November 30, 2020 18:15
mshustov added a commit to mshustov/kibana that referenced this pull request Nov 30, 2020
@mshustov
[Core] mark legacy ES client methods deprecated (elastic#84358)
d169f9b 
* mark context ES client & ES client methods deprecated

* update docs

* improve comment
@mshustov mshustov mentioned this pull request Nov 30, 2020
Merged
mshustov added a commit that referenced this pull request Nov 30, 2020
@mshustov
[Core] mark legacy ES client methods deprecated (#84358) (#84569)
9a6acb4 
* mark context ES client & ES client methods deprecated

* update docs

* improve comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

@timroes timroes timroes approved these changes

Assignees
No one assigned
Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mshustov @elasticmachine @kibanamachine @timroes @pgayvallet