Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default dedupKey value as an {{alertInstanceId}} to provide grouping functionality for PagerDuty incidents. #84598

Conversation

YulNaumenko
Copy link
Contributor

Added default dedupKey value as an {{alertId}}:{{alertInstanceId}} to provide grouping functionality for PagerDuty incidents.
Exposed getDefaultsForActionParams function which returns the default action params values for a selected action group

Resubmit of #77772

…uping functionality for PagerDuty incidents.
@YulNaumenko YulNaumenko added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.11.0 labels Dec 1, 2020
@YulNaumenko YulNaumenko self-assigned this Dec 1, 2020
@YulNaumenko YulNaumenko requested a review from a team as a code owner December 1, 2020 00:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Since this is a re-submit of the same PR, feel free to merge on green.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
triggersActionsUi 283 284 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.5MB 1.5MB +11.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@YulNaumenko YulNaumenko merged commit 67564b9 into elastic:master Dec 1, 2020
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Dec 1, 2020
…uping functionality for PagerDuty incidents. (elastic#84598)

* Added default dedupKey value as an {{alertInstanceId}} to provide grouping functionality for PagerDuty incidents.

* fixed type check
YulNaumenko added a commit that referenced this pull request Dec 1, 2020
…de grouping functionality for PagerDuty incidents. (#84598) (#84603)

* Added default dedupKey value as an {{alertInstanceId}} to provide grouping functionality for PagerDuty incidents. (#84598)

* Added default dedupKey value as an {{alertInstanceId}} to provide grouping functionality for PagerDuty incidents.

* fixed type check

* fixed type check
@mikecote mikecote added needs_docs release_note:enhancement and removed release_note:skip Skip the PR/issue when compiling release notes labels Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting needs_docs release_note:enhancement Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants