-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Initial API integration tests for ML jobs in spaces #84789
Conversation
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a nitpick comment, but on the whole LGTM.
Great work! Thanks for getting these tests in so quickly.
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
This PR adds initial API integration tests for the endpoints related to ML jobs in spaces.
Summary
This PR adds initial API integration tests for the endpoints related to ML jobs in spaces.
Details
Tests
Overall 57 new tests have been added for the following APIs:
Test services
ccommonConfig
andtestExecution
are now also available in API integration testsapi
service methods can now be called with aspace
parameter (optional) that will be used in the query URL:createAnomalyDetectionJob
createDatafeed
api
services are added:createAnomalyDetectionJobES
deleteAnomalyDetectionJobES
datafeedExist
waitForDatafeedToNotExist
createDatafeedES
deleteDatafeedES
closeAnomalyDetectionJob
createDataFrameAnalyticsJobES
asignJobToSpaces
removeJobFromSpaces
assertJobSpaces
api
servicetest_resources
service methods are added:getSavedObjectIdsByType
deleteMlSavedObjectByJobId
cleanMLSavedObjects