-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate painless autocomplete in runtime fields editor #84943
Integrate painless autocomplete in runtime fields editor #84943
Conversation
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alisonelizabeth , great job on adding autocomplete to runtime fields editor! I tested locally and all worked for me, changes in code LGTM too 👍
This PR integrates painless autocompletion in the runtime fields editor.
Continuation of #80577.
How to test
Verify autocomplete functionality is working in the runtime field editor. The runtime field editor is currently only integrated in the composable index template, legacy index template, and component template wizards.
For a list of available autocomplete functionality, check out the "Testing" section in #80577.
In order to test field autocompletion, you need to create at least one mapped field.
Known issues
I've received some feedback already around improvements that can be made to the autocomplete. I will handle these in a separate PR (#85055):
emit()
andparams
text
field types from the field autocomplete suggestions;text
field types are never in doc values.