Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Safeguarding alerts in case they come back undefined #85108

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

igoristic
Copy link
Contributor

Small regression from: #84676 cases an error on the clusters' listing page (.../app/monitoring#/home):

Screen Shot 2020-12-06 at 11 44 42 PM

@igoristic igoristic added Team:Monitoring Stack Monitoring team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v7.10.2 labels Dec 7, 2020
@igoristic igoristic requested a review from a team December 7, 2020 05:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 952.4KB 952.5KB +20.0B

Distributable file count

id before after diff
default 46897 47657 +760

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find! LGTM!

@igoristic
Copy link
Contributor Author

Backport:
7.x: e599cb3
7.10: 0356b73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Monitoring Stack Monitoring team v7.10.2 v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants