[Maps] Unify legend for percentiles, interpolate and custom ordinal color breaks #86050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… color breaks (elastic#85343) * [Maps] unify legend for percentiles, interpolate, and custom ordinal color breaks * unify mapbox style expression * snapshot updates * update jest expects * use less than and great than symbol for first and last stop * tslint * do not show legend if customColorRamp is not provided * update functional test expects * update functional test expect * update mapbox expect expressions in join functional tests * update mvt expects * revert mapbox style expression changes for interpole color ramp * add greater then and equal to symbol for last stop * disable stop input for first ordinal color stop Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
thomasneirynck
added
release_note:skip
|
Pinging @elastic/kibana-gis (Team:Geo) |
tylersmalley
approved these changes
Dec 15, 2020
kindsun
approved these changes
Dec 15, 2020
There was a problem hiding this comment.
@thomasneirynck Thanks for the offline walkthrough. lgtm w/ green CI!
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
Page load bundle
To update your PR or re-run it, just comment with: |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Dec 16, 2020
…olor breaks (elastic#86050) * [Maps] unify legend for percentiles, interpolate, and custom ordinal color breaks (elastic#85343) * [Maps] unify legend for percentiles, interpolate, and custom ordinal color breaks * unify mapbox style expression * snapshot updates * update jest expects * use less than and great than symbol for first and last stop * tslint * do not show legend if customColorRamp is not provided * update functional test expects * update functional test expect * update mapbox expect expressions in join functional tests * update mvt expects * revert mapbox style expression changes for interpole color ramp * add greater then and equal to symbol for last stop * disable stop input for first ordinal color stop Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * fix crossmerge Co-authored-by: Nathan Reese <reese.nathan@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
|
7.x #86069 |
nreese
added a commit
that referenced
this pull request
Dec 16, 2020
…olor breaks (#86050) (#86069) * [Maps] unify legend for percentiles, interpolate, and custom ordinal color breaks (#85343) * [Maps] unify legend for percentiles, interpolate, and custom ordinal color breaks * unify mapbox style expression * snapshot updates * update jest expects * use less than and great than symbol for first and last stop * tslint * do not show legend if customColorRamp is not provided * update functional test expects * update functional test expect * update mapbox expect expressions in join functional tests * update mvt expects * revert mapbox style expression changes for interpole color ramp * add greater then and equal to symbol for last stop * disable stop input for first ordinal color stop Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * fix crossmerge Co-authored-by: Nathan Reese <reese.nathan@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Thomas Neirynck <thomas@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #85343
This fixes the cross-merge issue raised here: #85343 (comment), by adding the
i18nimport back in.