Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] add typeToAgg for median #86078

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Dec 16, 2020

Summary

Fixes #85972 – bug was caused by an oversight from #84973

I modified one of the functional tests to configure median operation instead of configuring average, so we can know the lens editor was configured without errors – we test average in many places so I think it's a safe change.

@mbondyra mbondyra added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 Feature:Lens backport:skip This commit does not require backporting v7.11.0 v7.12.0 labels Dec 16, 2020
@mbondyra mbondyra force-pushed the lens/typeToFn-for-median branch from 0057243 to f79962e Compare December 16, 2020 04:46
@mbondyra mbondyra marked this pull request as ready for review December 16, 2020 04:48
@mbondyra mbondyra requested a review from a team December 16, 2020 04:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@mbondyra mbondyra added release_note:skip Skip the PR/issue when compiling release notes and removed backport:skip This commit does not require backporting labels Dec 16, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.0MB 1.0MB +19.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mbondyra mbondyra merged commit 800f79e into elastic:master Dec 16, 2020
mbondyra added a commit to mbondyra/kibana that referenced this pull request Dec 16, 2020
@mbondyra mbondyra deleted the lens/typeToFn-for-median branch December 16, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.11.0 v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Median operation blows the editor
4 participants