[data.search] Add extend functionality to server-side search service

[lukasolson]

Summary

Adds a third method, extend to search strategies. The purpose of this method is to extend the TTL of the given search ID by the given duration (or keep_alive).

Checklist

• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-app-services (Team:AppServices)

[lukasolson]

@elasticmachine merge upstream

[tsullivan]

Thoughts about validating the keepAlive string? It looks like it should be a valid time units string: https://www.elastic.co/guide/en/elasticsearch/reference/current/common-options.html#time-units

[lukasolson]

After giving this some thought, I think we can rely on the error/message we get back from Elasticsearch for this:

{
    "error": {
        "root_cause": [
            {
                "type": "illegal_argument_exception",
                "reason": "failed to parse setting [keep_alive] with value [foobar] as a time value: unit is missing or unrecognized"
            }
        ],
        "type": "illegal_argument_exception",
        "reason": "failed to parse setting [keep_alive] with value [foobar] as a time value: unit is missing or unrecognized"
    },
    "status": 400
}

[tsullivan]

The code LGTM but I'm not sure how to test the changes

[lizozom]

Cound you also add an api integration test for this API?

test/api_integration/apis/search/search.ts

[lukasolson]

Cound you also add an api integration test for this API?

This PR doesn't add any endpoints to access the extend functionality, since this extend method really only extends an individual search request (which we won't be allowing end users to do via an endpoint). When we add the method on the session service, we will add an endpoint and I can add the API integration test.

[lizozom]

LGTM

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 2725e35

Metrics [docs]

Distributable file count

id	before	after	diff
default	47252	48012	+760

History

• 💚 Build #96843 succeeded 2725e35
• 💚 Build #96803 succeeded 0bcfa4c
• 💔 Build #96748 failed 2b82ecf
• 💚 Build #95766 succeeded 02135f5
• 💚 Build #95020 succeeded 7b0c375

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream