Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switches rollup usage collector's fetch es client to the new client #86684

Merged
merged 5 commits into from
Jan 4, 2021
Merged

Switches rollup usage collector's fetch es client to the new client #86684

merged 5 commits into from
Jan 4, 2021

Conversation

TinaHeiligers
Copy link
Contributor

Summary

Part of #86358.
Refactors the rollup usage collector's fetch implementation to use the new elasticsearch client rather than the depricated legacy client.

For maintainers

@TinaHeiligers TinaHeiligers added Feature:Telemetry v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Rollups v7.12.0 labels Dec 21, 2020
@TinaHeiligers TinaHeiligers changed the title Switches rollup usage collector's fetch es client to the client Switches rollup usage collector's fetch es client to the new client Dec 21, 2020
@TinaHeiligers TinaHeiligers marked this pull request as ready for review December 21, 2020 22:26
@TinaHeiligers TinaHeiligers requested a review from a team as a code owner December 21, 2020 22:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@TinaHeiligers TinaHeiligers mentioned this pull request Dec 23, 2020
Closed
3 tasks
@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

jloleysens
jloleysens approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes @TinaHeiligers , I tested locally and can confirm they work. I tested this by making a request against the /api/stats endpoint and confirmed the code executed as expected. I assume this is enough of a test and will approve to unblock.

@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47266 48026 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers merged commit d6eda39 into elastic:master Jan 4, 2021
@TinaHeiligers TinaHeiligers deleted the rollup-usage-collector-fetch-client branch January 4, 2021 18:32
@TinaHeiligers TinaHeiligers mentioned this pull request Jan 4, 2021
Merged
TinaHeiligers added a commit that referenced this pull request Jan 4, 2021
@TinaHeiligers @kibanamachine
[7.x] Switches rollup usage collector's fetch es client to the new cl…
245c8c1 
…ient (#86684) (#87203)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jloleysens jloleysens jloleysens approved these changes

Assignees
No one assigned
Labels
Feature:Rollups Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TinaHeiligers @elasticmachine @kibanamachine @jloleysens