Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting UI] Make connector reducer as generic type. #86857

Conversation

YulNaumenko
Copy link
Contributor

@YulNaumenko YulNaumenko commented Dec 22, 2020

Current PR contains a changes to improve alerting UI type checks in connector reducer file.
Followed the pattern from the alert reducer, which was introduced by the PR #83278
Resolve #60274

@YulNaumenko YulNaumenko self-assigned this Dec 22, 2020
@YulNaumenko YulNaumenko linked an issue Jan 4, 2021 that may be closed by this pull request
@YulNaumenko YulNaumenko changed the title [Alerting UI] Make actions and alert reducers as generic type. [Alerting UI] Make connector reducer as generic type. Jan 4, 2021
@YulNaumenko YulNaumenko added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.12.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jan 5, 2021
@YulNaumenko YulNaumenko marked this pull request as ready for review January 5, 2021 19:58
@YulNaumenko YulNaumenko requested a review from a team as a code owner January 5, 2021 19:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.5MB 1.5MB +343.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@YulNaumenko YulNaumenko merged commit 1c30525 into elastic:master Jan 7, 2021
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Jan 7, 2021
* -

* fixed failing tests

* fixed typescript checks

* fixed typescript checks

* fixed failing build

* fixed typescript checks

* removed typo cast

* fixed failing test

* fixed faling build
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added backport missing Added to PRs automatically when the are determined to be missing a backport. and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Jan 11, 2021
YulNaumenko added a commit that referenced this pull request Jan 12, 2021
* -

* fixed failing tests

* fixed typescript checks

* fixed typescript checks

* fixed failing build

* fixed typescript checks

* removed typo cast

* fixed failing test

* fixed faling build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Alerting UI] Make actions and alert reducers as generic type
4 participants