Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for setting server.host to '0' (breaking) #87114

Merged
merged 3 commits into from
Jan 6, 2021

Conversation

watson
Copy link
Contributor

@watson watson commented Jan 4, 2021

Support for this was originally a side-effect of our old version of hapi (pre v20). hapi v20 does no longer support this, so a workaround was added to not break expectations. This PR removes that workaround for v8.0.0 as it's considered a breaking change.

Besides, in the new version of joi, 0 is no longer considered a valid hostname, so when we upgrade, this extra validate function can be removed.

Todo

Release note

Removes support for configuring Kibana with 0 as the server.host.

@watson
Copy link
Contributor Author

watson commented Jan 4, 2021

@graphaelli You mentioned that we list 0 as a valid config option in the docs somewhere. Do you mind pointing me in the right direction?

@watson watson marked this pull request as ready for review January 4, 2021 18:51
@watson watson requested review from a team as code owners January 4, 2021 18:51
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker config change LGTM, but want to make sure @jbudz sees this and doesn't have any issue with it.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47262 48025 +763

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@watson watson merged commit b0a66da into elastic:master Jan 6, 2021
@watson watson deleted the server-host branch January 6, 2021 12:12
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 8, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 87114 or prevent reminders by adding the backport:skip label.

mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Jan 11, 2021
@watson watson added the backport:skip This commit does not require backporting label Jan 11, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 11, 2021
mdelapenya added a commit to elastic/e2e-testing that referenced this pull request Jan 11, 2021
* fix: use proper server.host in Kibana

See elastic/kibana#87114

* fix: switch to the official namespaces to consume upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:breaking v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants