-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for setting server.host to '0' (breaking) #87114
Conversation
@graphaelli You mentioned that we list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docker config change LGTM, but want to make sure @jbudz sees this and doesn't have any issue with it.
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
* fix: use proper server.host in Kibana See elastic/kibana#87114 * fix: switch to the official namespaces to consume upstream
Support for this was originally a side-effect of our old version of hapi (pre v20). hapi v20 does no longer support this, so a workaround was added to not break expectations. This PR removes that workaround for v8.0.0 as it's considered a breaking change.
Besides, in the new version of joi,
0
is no longer considered a valid hostname, so when we upgrade, this extravalidate
function can be removed.Todo
0
as theirserver.host
(Use 0.0.0.0 instead of 0 as server.host elastic-package#211)0
0
??Release note
Removes support for configuring Kibana with
0
as theserver.host
.