Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Telemetry plugins esclient migration #87356

Merged
merged 3 commits into from
Jan 6, 2021
Merged

Telemetry plugins esclient migration #87356

merged 3 commits into from
Jan 6, 2021

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Jan 5, 2021 •
edited
Loading

Summary

Migrates the telemetry-related plugins' elasticsearch client to the new client.
Removes support for the legacy elasticsearch client from the usage_collector's fetch context.
Resolves #83124

Checklist

Delete any items that are not applicable to this PR.

For maintainers

Dev docs

This PR removes support for the legacy elasticsearch client from the usage collector's fetch context

@TinaHeiligers TinaHeiligers added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Telemetry release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. v8.0.0 v7.12.0 labels Jan 5, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47252 48012 +760

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers mentioned this pull request Jan 5, 2021
Closed
3 tasks
@TinaHeiligers TinaHeiligers marked this pull request as ready for review January 5, 2021 21:26
@TinaHeiligers TinaHeiligers requested review from a team as code owners January 5, 2021 21:26
@TinaHeiligers TinaHeiligers requested a review from a team January 5, 2021 21:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

mattkime
mattkime approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App Services changes lgtm

Bamieh
Bamieh approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TinaHeiligers TinaHeiligers merged commit 70c7087 into elastic:master Jan 6, 2021
@TinaHeiligers TinaHeiligers deleted the telemetry-plugins-esclient-migration branch January 6, 2021 19:57
@TinaHeiligers TinaHeiligers mentioned this pull request Jan 6, 2021
Merged
TinaHeiligers added a commit that referenced this pull request Jan 6, 2021
@TinaHeiligers
[7.x] Telemetry plugins esclient migration (#87356) (#87570)
3e172d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bamieh Bamieh Bamieh approved these changes

@mattkime mattkime mattkime approved these changes

@chrisronline chrisronline chrisronline approved these changes

Assignees
No one assigned
Labels
Feature:Telemetry release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Telemetry][Usage Collection] Finish migration to the new elasticsearch client
6 participants
@TinaHeiligers @kibanamachine @elasticmachine @chrisronline @mattkime @Bamieh