Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken documentation link in Lens app #87392

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jan 5, 2021

Summary

The drop-down help menu for the Lens app contains a link to https://www.elastic.co/guide/en/kibana/master/lens.html, which is a deleted page.

This PR adds a new keyword in the documentation link service for the Lens documentation and uses that keyword in the help menu.

Screenshot

image

@lcawl lcawl added Feature:Lens v7.12.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Docs labels Jan 5, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.0MB 1.0MB -70.0B

Distributable file count

id before after diff
default 47260 48020 +760

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 564.0KB 564.1KB +128.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl marked this pull request as ready for review January 6, 2021 16:30
@lcawl lcawl requested a review from a team January 6, 2021 16:30
@lcawl lcawl requested a review from a team as a code owner January 6, 2021 16:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@lcawl lcawl requested a review from KOTungseth January 6, 2021 16:30
@lcawl lcawl merged commit 9a17446 into elastic:master Jan 7, 2021
@lcawl lcawl deleted the doclinks-lens branch January 7, 2021 17:13
lcawl added a commit to lcawl/kibana that referenced this pull request Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants