Use documentation link service for security links #87409
Conversation
lcawl
force-pushed
the
security-doclinks
branch
from
e9a1864
to
b10e3c7
Compare
|
|
||
| constructor(docLinks: DocLinksStart) { | ||
| this.esDocBasePath = `${docLinks.ELASTIC_WEBSITE_URL}guide/en/elasticsearch/reference/${docLinks.DOC_LINK_VERSION}/`; | ||
| this.apiKeySettings = `${docLinks.links.security.apiKeyServiceSettings}`; |
There was a problem hiding this comment.
this.apiKeySettings =
${docLinks.links.security.apiKeyServiceSettings};
If it's preferrable to remove these definitions and use the doc links service directly in the subsequent functions, I can make that change.
There was a problem hiding this comment.
Yeah, if you can use the links service directly that would be great, thanks!
There was a problem hiding this comment.
Actually I think we don't need our own DocumentationLinksService's anymore. But if it's too much for this PR then I'm fine to keep it as is and we'll remove these services in the follow up.
There was a problem hiding this comment.
Sure, if we do the cleanup in a subsequent PR that works for me!
lcawl
added
Feature:Security/Authorization
|
Pinging @elastic/kibana-docs (Team:Docs) |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
Summary
This PR updates hard-coded links to security documentation such that they use the documentation link service instead, which is easier to maintain.