[data.search] Add search session methods to search service contract #87966

lukasolson · 2021-01-12T03:41:16Z

Summary

This PR changes what we register on the route handler context for search. Prior, we were registering a search key that had a session property where all of the session methods lived. After, the session methods are directly on the search key. (For example, what used to be search.session.save is now search.saveSession.) This allows us to simplify the dependencies so that a scoped search session client is passed to each of the search service methods.

This PR also adds the extendSession method to the search service, which extends the session expiration and each individual search request associated with the session.

lizozom

I'm really happy with how this PR turned out!
Guess that there's nothing really to test here, just the conceptual changes. Right?

src/plugins/data/public/search/session/sessions_client.ts

src/plugins/data/server/search/search_service.ts

src/plugins/data/server/search/session/types.ts

x-pack/plugins/data_enhanced/server/search/session/session_service.test.ts

x-pack/plugins/data_enhanced/server/search/session/session_service.ts

elasticmachine · 2021-01-14T22:01:56Z

Pinging @elastic/kibana-app-services (Team:AppServices)

src/plugins/data/server/search/search_service.ts

Kerry350

Logs and metrics changes LGTM

lizozom

LGTM once green :)

stratoula

kibana app changes LGTM 🙂

lizozom

@lukasolson I just realized that some of this refactoring might be problematic.
We need to be able to actually extend the search requests from the monitoring service, so we'd still need to have access to the search service from the session service. I think we must fix this in this PR, otherwise, we'll end up refactoring again in the next one :-\

…session-api

lukasolson · 2021-01-28T23:11:45Z

@elasticmachine merge upstream

lizozom

Considering the changes in #89570
This LGTM

lizozom · 2021-02-02T14:26:40Z

x-pack/plugins/data_enhanced/server/search/session/session_service.ts

+        find: this.find.bind(this, deps),
+        update: this.update.bind(this, deps),
+        extend: this.extend.bind(this, deps),
+        cancel: this.cancel.bind(this, deps),


@lukasolson could you please keep both cancel and delete APIs, so we have some flexibility?

lukasolson · 2021-02-02T23:20:28Z

@lizozom Before I merge this PR, I wanted to check with you... Since this moves some of the logic out of the session service into the search service, it will definitely conflict with your PR [1], and I wanted to be sure we're fine with how these changes will interact with the changes you've made in your PR.

[1] #89570

lizozom · 2021-02-03T10:49:02Z

I merged your PR into mine, so feel free to merge first. :)

kibanamachine · 2021-02-03T14:05:11Z

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`data`	798.2KB	798.4KB	+157.0B

History

💔 Build #103347 failed 5c564c2
💚 Build #103204 succeeded fbfc1b1
💔 Build #103072 failed e582910
💚 Build #102783 succeeded 99dc347
💔 Build #102723 failed 99b4ca0

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…lastic#87966) * [data.search] Add search session methods to search service contract * Fix types * Fix tests and switch to cancel * Update docs * Fix types/tests * Fix tests * Update status of SO before cancelling search requests * Add API integration test * Fix types * Update expiration route to use config defaultExpiration * Fix test * Update docs * New logic for extend * Remove declare module * Review feedback * fix ts * Remove test that is no longer valid * Fix undefined bug * Use DataRequestHandlerContext in maps * ts Co-authored-by: Liza K <liza.katz@elastic.co>

…87966) (#90187) * [data.search] Add search session methods to search service contract * Fix types * Fix tests and switch to cancel * Update docs * Fix types/tests * Fix tests * Update status of SO before cancelling search requests * Add API integration test * Fix types * Update expiration route to use config defaultExpiration * Fix test * Update docs * New logic for extend * Remove declare module * Review feedback * fix ts * Remove test that is no longer valid * Fix undefined bug * Use DataRequestHandlerContext in maps * ts Co-authored-by: Liza K <liza.katz@elastic.co> Co-authored-by: Liza K <liza.katz@elastic.co>

[data.search] Add search session methods to search service contract

c22024f

lukasolson added Feature:Search Querying infrastructure in Kibana WIP Work in progress v8.0.0 Team:AppServices release_note:skip Skip the PR/issue when compiling release notes Project:AsyncSearch Background search, partial results, async search services. v7.12.0 labels Jan 12, 2021

lukasolson self-assigned this Jan 12, 2021

This was referenced Jan 12, 2021

[data.search.session] Change search session client to implement plugin #86815

Closed

[skip-ci] [data.search.session] Add extend functionality and expose route #87370

Closed

lizozom reviewed Jan 13, 2021

View reviewed changes

lukasolson removed the WIP Work in progress label Jan 14, 2021

lukasolson marked this pull request as ready for review January 14, 2021 22:01

lukasolson requested a review from a team as a code owner January 14, 2021 22:01

lukasolson added 2 commits January 15, 2021 13:41

Merge branch 'master' into search-session-api

1046c54

Fix types

7040716

lukasolson requested a review from a team as a code owner January 15, 2021 21:10

lukasolson added 4 commits January 15, 2021 14:57

Fix tests and switch to cancel

eeddf84

Update docs

f09eb38

Merge branch 'master' into search-session-api

e6124af

Fix types/tests

e160019

lukasolson commented Jan 19, 2021

View reviewed changes

src/plugins/data/server/search/search_service.ts Show resolved Hide resolved

lukasolson added 3 commits January 19, 2021 14:41

Fix tests

3c08c3d

Update status of SO before cancelling search requests

0cd92ed

Add API integration test

f1a1d0b

Kerry350 approved these changes Jan 20, 2021

View reviewed changes

lukasolson added 2 commits January 20, 2021 12:25

Merge branch 'master' into search-session-api

552e545

Merge branch 'master' into search-session-api

ee6e337

lukasolson and others added 4 commits January 26, 2021 14:41

Remove declare module

71582c7

Review feedback

65840b3

Merge branch 'master' of github.com:elastic/kibana into pr/87966

fdb940b

fix ts

b2bce4b

lizozom approved these changes Jan 27, 2021

View reviewed changes

stratoula approved these changes Jan 27, 2021

View reviewed changes

lizozom suggested changes Jan 27, 2021

View reviewed changes

lukasolson added 4 commits January 28, 2021 08:47

Merge branch 'master' into search-session-api

50081b5

Remove test that is no longer valid

e24181c

Merge remote-tracking branch 'origin/search-session-api' into search-…

08ed572

…session-api

Merge branch 'master' into search-session-api

44ef260

lizozom approved these changes Feb 1, 2021

View reviewed changes

Merge branch 'master' into search-session-api

99b4ca0

lukasolson force-pushed the search-session-api branch from 94672b4 to 99b4ca0 Compare February 1, 2021 19:16

Fix undefined bug

99dc347

lizozom reviewed Feb 2, 2021

View reviewed changes

lukasolson added 2 commits February 2, 2021 09:52

Merge branch 'master' into search-session-api

e582910

Fix types

fbfc1b1

Liza K added 3 commits February 3, 2021 12:53

Merge branch 'master' of github.com:elastic/kibana into pr/87966

5c564c2

Use DataRequestHandlerContext in maps

3eb8f01

ts

6462da6

lizozom mentioned this pull request Feb 3, 2021

[Search Sessions] Save all sessions, with persisted flag #89570

Merged

9 tasks

lukasolson merged commit a9273ca into elastic:master Feb 3, 2021

lukasolson mentioned this pull request Feb 3, 2021

[7.x] [data.search] Add search session methods to search service contract (#87966) #90187

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[data.search] Add search session methods to search service contract #87966

[data.search] Add search session methods to search service contract #87966

lukasolson commented Jan 12, 2021 •

edited

Loading

lizozom left a comment

elasticmachine commented Jan 14, 2021

Kerry350 left a comment

lizozom left a comment •

edited

Loading

stratoula left a comment

lizozom left a comment

lukasolson commented Jan 28, 2021

lizozom left a comment

lizozom Feb 2, 2021

lizozom Feb 2, 2021

lukasolson commented Feb 2, 2021

lizozom commented Feb 3, 2021 •

edited

Loading

kibanamachine commented Feb 3, 2021

[data.search] Add search session methods to search service contract #87966

[data.search] Add search session methods to search service contract #87966

Conversation

lukasolson commented Jan 12, 2021 • edited Loading

Summary

lizozom left a comment

Choose a reason for hiding this comment

elasticmachine commented Jan 14, 2021

Kerry350 left a comment

Choose a reason for hiding this comment

lizozom left a comment • edited Loading

Choose a reason for hiding this comment

stratoula left a comment

Choose a reason for hiding this comment

lizozom left a comment

Choose a reason for hiding this comment

lukasolson commented Jan 28, 2021

lizozom left a comment

Choose a reason for hiding this comment

lizozom Feb 2, 2021

Choose a reason for hiding this comment

lizozom Feb 2, 2021

Choose a reason for hiding this comment

lukasolson commented Feb 2, 2021

lizozom commented Feb 3, 2021 • edited Loading

kibanamachine commented Feb 3, 2021

💚 Build Succeeded

Metrics [docs]

Page load bundle

History

lukasolson commented Jan 12, 2021 •

edited

Loading

lizozom left a comment •

edited

Loading

lizozom commented Feb 3, 2021 •

edited

Loading