Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle another node already having deleted the temporary index #88332

Merged
merged 6 commits into from
Jan 21, 2021

Conversation

rudolf
Copy link
Contributor

@rudolf rudolf commented Jan 14, 2021

Summary

Handles the temporary index already being deleted by another node as described in #84333

Related #75780

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@rudolf rudolf added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.12.0 project:ResilientSavedObjectMigrations Reduce Kibana upgrade failures by making saved object migrations more resilient 8.0.0 labels Jan 14, 2021
@rudolf rudolf added the release_note:skip Skip the PR/issue when compiling release notes label Jan 14, 2021
@rudolf rudolf marked this pull request as ready for review January 14, 2021 14:29
@rudolf rudolf requested a review from a team as a code owner January 14, 2021 14:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@rudolf
Copy link
Contributor Author

rudolf commented Jan 15, 2021

@elasticmachine merge upstream

Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a couple of NITs regarding the bash script.

@rudolf rudolf requested a review from afharo January 15, 2021 13:32
# kibana_index - search .kibana index against es
#

FN="$1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: Not everyone knows bash as well as JS. What functionality not supported by JS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's anything here that couldn't be implemented in JS, but I suspect it would just be a bit harder and more code to deal with async and streaming output between processes/files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, it would be good to have a long term goal of including multi-node upgrade migrations in automated tests. It would be much easier to implement such a test (and remove this script) once we have node clustering support #68626

rm processes.out
for i in $(seq 0 $(expr $NUM - 1))
do
PORT="56${i}1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI doesn't run the script. Does it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it's just for manual QA

@rudolf
Copy link
Contributor Author

rudolf commented Jan 18, 2021

@elasticmachine merge upstream

Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since all the comments are based on the manual QA script test/scripts/run_multiple_kibana_nodes.sh, but the actual code is correct, I'll 👍 this PR.

@rudolf
Copy link
Contributor Author

rudolf commented Jan 20, 2021

@elasticmachine merge upstream

@rudolf rudolf requested a review from mshustov January 20, 2021 15:12
@wylieconlon wylieconlon added v8.0.0 and removed 8.0.0 labels Jan 20, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rudolf rudolf merged commit bfcd990 into elastic:master Jan 21, 2021
@rudolf rudolf deleted the so-migrations-v2-temp-index-not-found branch January 21, 2021 11:10
rudolf added a commit to rudolf/kibana that referenced this pull request Jan 21, 2021
…ic#88332)

* Handle another node already having deleted the temporary index

* Make run_multiple_kibana_nodes.sh script more generic

* Add note about dependency on jq

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
rudolf added a commit that referenced this pull request Jan 21, 2021
… (#88949)

* Handle another node already having deleted the temporary index

* Make run_multiple_kibana_nodes.sh script more generic

* Add note about dependency on jq

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project:ResilientSavedObjectMigrations Reduce Kibana upgrade failures by making saved object migrations more resilient release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants