-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alerting] Migrate Actions, Alerts, Stack Alerts and TriggersActionsUI plugins to TS project references #88556
[Alerting] Migrate Actions, Alerts, Stack Alerts and TriggersActionsUI plugins to TS project references #88556
Conversation
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM! I'm guessing TS wasn't happy about requiring constants from the security team's code?
Yes, the other solution was add the plugin to the required list, which I decided is not necessary just for adding the constants. |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…I plugins to TS project references (elastic#88556) * [Alerting] Migrate Actions plugin to TS project references * alerts plugin ts migration * triggers_actions_ui plugin ts migration * fixed build * fixed build
Resolve one required from Plugins to migrate:
Added
tsconfig.json
file to event_log plugin folder with the proper configuration optimization options, which described in the documentation. This changes should improve build times and enforce logical separation between components.