Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting] Migrate Actions, Alerts, Stack Alerts and TriggersActionsUI plugins to TS project references #88556

Merged

Conversation

YulNaumenko
Copy link
Contributor

@YulNaumenko YulNaumenko commented Jan 16, 2021

Resolve one required from Plugins to migrate:

  • actions
  • alerts
  • stack_alerts
  • triggers_actions_ui

Added tsconfig.json file to event_log plugin folder with the proper configuration optimization options, which described in the documentation. This changes should improve build times and enforce logical separation between components.

@YulNaumenko YulNaumenko added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Actions Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.12.0 labels Jan 16, 2021
@YulNaumenko YulNaumenko self-assigned this Jan 16, 2021
@YulNaumenko YulNaumenko requested a review from a team as a code owner January 16, 2021 03:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@YulNaumenko YulNaumenko changed the title [Alerting] Migrate Actions plugin to TS project references [Alerting] Migrate Actions and Alerts plugins to TS project references Jan 16, 2021
@YulNaumenko YulNaumenko changed the title [Alerting] Migrate Actions and Alerts plugins to TS project references [Alerting] Migrate Actions, Alerts, Stack Alerts and TriggersActionsUI plugins to TS project references Jan 16, 2021
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! I'm guessing TS wasn't happy about requiring constants from the security team's code?

@YulNaumenko
Copy link
Contributor Author

Changes LGTM! I'm guessing TS wasn't happy about requiring constants from the security team's code?

Yes, the other solution was add the plugin to the required list, which I decided is not necessary just for adding the constants.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YulNaumenko YulNaumenko merged commit 8b1a228 into elastic:master Jan 20, 2021
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Jan 20, 2021
…I plugins to TS project references (elastic#88556)

* [Alerting] Migrate Actions plugin to TS project references

* alerts plugin ts migration

* triggers_actions_ui plugin ts migration

* fixed build

* fixed build
YulNaumenko added a commit that referenced this pull request Jan 20, 2021
…I plugins to TS project references (#88556) (#88894)

* [Alerting] Migrate Actions plugin to TS project references

* alerts plugin ts migration

* triggers_actions_ui plugin ts migration

* fixed build

* fixed build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Actions Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Alerting plugins (including Task Manager and Event Log) to TS project references
5 participants