Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use doc link service for Maps help #88631

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Use doc link service for Maps help #88631

merged 1 commit into from
Jan 19, 2021

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jan 18, 2021

Summary

Relates to #88107

This PR fixes the maps URL in the doc link service and uses that keyword in the help menu for the Maps app (rather than a hard-coded link).

@lcawl lcawl added Team:Docs v7.12.0 8.0.0 [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes and removed Team:Docs labels Jan 18, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.9MB 2.9MB -159.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 564.6KB 564.6KB -7.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl marked this pull request as ready for review January 18, 2021 23:55
@lcawl lcawl requested a review from a team as a code owner January 18, 2021 23:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@pgayvallet
Copy link
Contributor

@elastic/kibana-gis Seems like maps codeowner is commented:

kibana/.github/CODEOWNERS

Lines 123 to 124 in 273ad4e

# Maps
#CC# /x-pack/plugins/maps/ @elastic/kibana-gis

@pgayvallet pgayvallet requested a review from a team January 19, 2021 14:35
nreese
nreese approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for converting to the doc link service
code review, tested in chrome

@lcawl lcawl merged commit 1db3235 into elastic:master Jan 19, 2021
@lcawl lcawl deleted the maps-link branch January 19, 2021 21:52
lcawl added a commit to lcawl/kibana that referenced this pull request Jan 19, 2021
@lcawl
Use doc link service for Maps help (elastic#88631)
0c4a820
@lcawl lcawl mentioned this pull request Jan 19, 2021
Merged
lcawl added a commit that referenced this pull request Jan 20, 2021
@lcawl
Use doc link service for Maps help (#88631) (#88769)
12a145c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

@nreese nreese nreese approved these changes

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lcawl @kibanamachine @elasticmachine @pgayvallet @nreese