[ILM] Policy phases redesign #88671
Merged
[ILM] Policy phases redesign #88671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuliacech
added
Feature:ILM
Team:Kibana Management
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
|
@elasticmachine merge upstream |
yuliacech
commented
Jan 26, 2021
| return ( | ||
| isNewPolicy || // enable index priority for new policies | ||
| !policy.phases[phase]?.actions || // enable index priority for new phases | ||
| policy.phases[phase]?.actions?.set_priority != null // enable index priority if it's set |
There was a problem hiding this comment.
Hi @jloleysens , here is a change to setting default index priority we discussed. Could you please have a look?
There was a problem hiding this comment.
Thanks, this makes sense to me! @andreidan @dakrone , this is in line with the current index priority behaviour. I wonder if at this time we can change the past behavior and exclude index priority by default on phases. Currently, it is on for all phases by default for new policies, with defaults for hot being highest, warm second highest and cold lowest.
jloleysens
approved these changes
Jan 26, 2021
There was a problem hiding this comment.
Excellent work @yuliacech, this is a very cool enhancement!
Happy for you to merge, it would be cool to drive the question about index priority to its conclusion here, but I think we can also return to it 👍🏻
| return ( | ||
| isNewPolicy || // enable index priority for new policies | ||
| !policy.phases[phase]?.actions || // enable index priority for new phases | ||
| policy.phases[phase]?.actions?.set_priority != null // enable index priority if it's set |
There was a problem hiding this comment.
Thanks, this makes sense to me! @andreidan @dakrone , this is in line with the current index priority behaviour. I wonder if at this time we can change the past behavior and exclude index priority by default on phases. Currently, it is on for all phases by default for new policies, with defaults for hot being highest, warm second highest and cold lowest.
mdefazio
approved these changes
Jan 26, 2021
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
yuliacech
added
release_note:skip
yuliacech
added a commit
to yuliacech/kibana
that referenced
this pull request
Jan 27, 2021
* Phases redesign * Title and name field layout * Active highlight wip * Copy comments * Updated data allocation dropdown * Min age error message * Fixed tests * Fixed edit policy integration tests * Fixed more tests * Cleaned up test files * Use hotProperty instead of a string * Clean up in phase component * Fixed i18n files * Updated optional fields * Updated aria attributes after running axe tests * Added review suggestions * Reversed data allocation field changes * Fixed type error * Reversed on/off label and prepend input label * Deleted property consts from phases components * Removed not needed i18n consts and added i18n where missing * Fixed merge conflicts with master Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
yuliacech
added a commit
that referenced
this pull request
Jan 28, 2021
* Phases redesign * Title and name field layout * Active highlight wip * Copy comments * Updated data allocation dropdown * Min age error message * Fixed tests * Fixed edit policy integration tests * Fixed more tests * Cleaned up test files * Use hotProperty instead of a string * Clean up in phase component * Fixed i18n files * Updated optional fields * Updated aria attributes after running axe tests * Added review suggestions * Reversed data allocation field changes * Fixed type error * Reversed on/off label and prepend input label * Deleted property consts from phases components * Removed not needed i18n consts and added i18n where missing * Fixed merge conflicts with master Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This was referenced Jan 28, 2021
1 task
jloleysens
added
release_note:feature
💔 Build Failed
Failed CI Steps
Test FailuresChrome X-Pack UI Functional Tests.x-pack/test/functional/apps/ml/data_frame_analytics/cloning·ts.machine learning data frame analytics jobs cloning supported by UI form classification job supported by the form opens the existing job in the data frame analytics job wizardStandard OutStack TraceX-Pack EPM API Integration Tests.x-pack/test/fleet_api_integration/apis/fleet_setup·ts.Fleet Endpoints fleet_setup should not create a fleet_enroll role if one does not already existStandard OutStack TraceX-Pack API Integration Tests.x-pack/test/api_integration/apis/ml/modules/setup_module·ts.apis Machine Learning modules module setup sets up module data for logs_ui_categories with prefix, startDatafeed true and estimateModelMemory trueStandard OutStack Traceand 3 more failures, only showing the first 3. Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a part of data tiers redesign work in ILM.
Changes include:
All form controls in a phase use 'on/off' labels and hide any additional controls if disabledAll form controls have a new style (prepend label)Screenshots
Expand to see screenshots
Edit policy form
Hot phase expanded form
Warm phase expanded form
Cold phase expanded form
Checklist
Delete any items that are not applicable to this PR.
How to test
yarn kbn bootstrapyarn startandyarn es snapshotin a separate terminal tabThere is a possibility to test with the Amsterdam theme in Kibana:
v7tov8(beta)TODO in following PRs
Release note
Data tier formalization in Elasticsearch offers a built-in way of stratifying nodes into different tiers, from fastest to slowest machines. Data is allocated to tiers using ILM phases, which prompted a redesign of the previous ILM UI and UX. The new UI and UX is designed to:
Screenshots
Toggle screenshots
Gif