-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs UI] Display category in anomalies table #88677
[Logs UI] Display category in anomalies table #88677
Conversation
Cleanup http types leaking into UI and server side libs
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
…egory-in-anomalies-table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…egory-in-anomalies-table
@afgomez Thanks for the review 🙏 I've fixed the alignment. Switched for a centre alignment on the arrow. And sorted the mobile break. |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* Add category pattern to anomalies table
Summary
This PR implements #79770.
It reuses the
fetchLogEntryCategories
function, and then decorates the category anomalies with extra information.Reviewing
The changeset makes this look quite overwhelming as there's a lot of type cleanup. But the actual functionality changes are contained to 6a1214b and fa4a6cd.
9b220a1 can initially be filtered out for a better view.
(This isn't perfect, as there were a few tweaks to the core functionality to satisfy the type changes, but this should at least help to see the main idea of fetching the category information and rendering it).
Type cleanup
Please see #88051 (comment) and #88051 (comment) for the initial motivation.
I've tried to move HTTP types (those in
http_api
) away from the UI and server side concerns that aren't routes. The only places directly dealing with the HTTP types should now be service calls, data hooks, and routes. But not things like query generation, libs etc.I've moved general "entities" into other
common
locations, which the UI and libs etc can then also use. The HTTP types are then comprised of these more general types.This was only supposed to be a change for the ML functionality, but due to the log entry examples this did end up creeping somewhat into log entries as well.