Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Uses doc link service in discover #88835

Merged
merged 13 commits into from
Feb 3, 2021
Merged

[DOCS] Uses doc link service in discover #88835

merged 13 commits into from
Feb 3, 2021

Conversation

szabosteve
Copy link
Contributor

Summary

This PR changes a hard-coded link to a const that uses doc link service.

@szabosteve szabosteve requested a review from a team January 20, 2021 13:54
@szabosteve szabosteve requested a review from a team as a code owner January 20, 2021 13:54
@szabosteve szabosteve marked this pull request as draft January 20, 2021 13:55
@szabosteve szabosteve added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Jan 20, 2021
@elastic elastic deleted a comment from kibanamachine Jan 20, 2021
@elastic elastic deleted a comment from kibanamachine Jan 20, 2021
@elastic elastic deleted a comment from kibanamachine Jan 20, 2021
@szabosteve
Copy link
Contributor Author

@elasticmachine merge upstream

@elastic elastic deleted a comment from kibanamachine Jan 20, 2021
@szabosteve szabosteve marked this pull request as ready for review January 21, 2021 08:40
@szabosteve
Copy link
Contributor Author

@elasticmachine merge upstream

@szabosteve
Copy link
Contributor Author

@elasticmachine merge upstream

@szabosteve
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 413.0KB 413.0KB -27.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 464.6KB 464.6KB +55.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kertal
Copy link
Member

kertal commented Feb 2, 2021

ACK, will review

@kertal kertal added Feature:Discover Discover Application v7.12.0 labels Feb 3, 2021
kertal
kertal approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KibanaApp owned Code LGTM, seems this could be currently dead code, since I had to manually trigger this error message, will open an issue for that. When it's displayed it works, tested locally in Chrome, MacOs

However, thx for removing this static link 👍

@kertal kertal mentioned this pull request Feb 3, 2021
Closed
@szabosteve szabosteve merged commit d560b1c into elastic:master Feb 3, 2021
@szabosteve szabosteve deleted the i/88107 branch February 3, 2021 07:54
This was referenced Feb 3, 2021
Merged
Closed
szabosteve added a commit that referenced this pull request Feb 3, 2021
@szabosteve @kibanamachine @lcawl
[DOCS] Uses doc link service in discover (#88835) (#90127)
9427780 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: lcawl <lcawley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@szabosteve @kibanamachine @kertal @pgayvallet @lcawl