-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] Add table source for choropleth mapping #89263
[Maps] Add table source for choropleth mapping #89263
Conversation
x-pack/plugins/maps/common/descriptor_types/source_descriptor_types.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/common/descriptor_types/source_descriptor_types.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/classes/sources/table_source/table_source.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/common/descriptor_types/source_descriptor_types.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/common/descriptor_types/source_descriptor_types.ts
Outdated
Show resolved
Hide resolved
|
||
export class GeoJsonFileField extends AbstractField implements IField { | ||
private readonly _source: GeoJsonFileSource; | ||
export class InlineField<T extends IVectorSource> extends AbstractField implements IField { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should getSource
method return T
instead of IVectorSource
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that's necessary. IVectorSource
is the more generic return-type and none of the other IFields
substitute this type for amore specific instance either. getSource
is also the method that we want to remove from IField
.
Pinging @elastic/kibana-gis (Team:Geo) |
x-pack/plugins/maps/public/classes/sources/table_source/table_source.test.ts
Outdated
Show resolved
Hide resolved
Pinging @elastic/uptime (Team:uptime) |
Pinging @elastic/apm-ui (Team:apm) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
code review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, UX app working fine with this patch.
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Summary
This adds a new source
TABLE_SOURCE
that can be used in descriptors to inject custom tabular data to use in a term join.Intended for users of the
MapsEmbeddable
, so they can do choropleth mapping with custom data (e.g. mash up an EMS layer with a custom table).This is a follow-on to the ML work here: #88416. It would allow ML to map anomalies by state/country.
Example: