[kbn/pm] throw an error if package doesn't have a script #89438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
release_note:skip
|
Pinging @elastic/kibana-operations (Team:Operations) |
brianseeders
approved these changes
Jan 27, 2021
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
This was referenced Jan 27, 2021
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Jan 27, 2021
* [kbn/pm] throw an error if package doesn't have a script * actually add the kbn/es build script 🤦♂️ Co-authored-by: spalger <spalger@users.noreply.github.com>
spalger
added a commit
that referenced
this pull request
Jan 27, 2021
…) (#89463) * [kbn/pm] throw an error if package doesn't have a script * actually add the kbn/es build script 🤦♂️ Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: spalger <spalger@users.noreply.github.com>
kibanamachine
added
the
backport missing
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
spalger
added a commit
that referenced
this pull request
Jan 29, 2021
… (#89462) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brianseeders noticed that running
yarn kbn run build -i @kbn/eswasn't building the kbn/es package, but it wasn't clear why. Turns out in #78090 I didn't actually add a "build" script to package.json. This add that script and updates kbn/pm to validate the script is actually available in the packages you select when usingyarn kbn run. This check can be skipped by passing--skip-missing.