Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows IE test timeouts in Events and Fetch service #8969

Closed
wants to merge 3 commits into from

Conversation

LeeDr
Copy link

@LeeDr LeeDr commented Nov 4, 2016

Kibana version: master (6.0.0-alpha1)

Elasticsearch version: master

Server OS version: Windows 10

Browser version: IE 11

Browser OS version: Windows 10

Original install method (e.g. download page, yum, from source, etc.): dev testing

Description of the problem including expected versus actual behavior: Several browser tests are failing for me on Windows 10 with IE 11. At least one of them is a timeout at 10s. If I bump the timeout up to 20 seconds they pass. We know IE is slower than other browsers at some tasks. I think we should bump the timeout up to avoid false failures.

OR - is this really unacceptable performance on these tasks and we need to look into it instead of making the timeout longer?

Steps to reproduce:

  1. npm run test:dev
  2. When IE 11 browser opens, create new tab and paste
    http://localhost:9876/debug.html?grep=Fetch%20service

http://localhost:9876/debug.html?grep=Fetch%20service

Fetch service
#doc(docSource)

fetches a single doc source7883ms

#search(searchSource)

fetches a single search source

Error: timeout of 10000ms exceeded. Ensure the done() callback is being called in this test.

This test above passed when I changed the timeout to 20000ms. It actually passed in 9541ms in this case.

Passed again in 9698ms

Passed again in 10606ms

With some load applied on my laptop I can get them well past 10s;
image

Same with Events tests;
image

diff --git a/tasks/config/karma.js b/tasks/config/karma.js
index e19ea74..1fd83a5 100644
--- a/tasks/config/karma.js
+++ b/tasks/config/karma.js
@@ -36,7 +36,7 @@ module.exports = function (grunt) {
       client: {
         mocha: {
           reporter: 'html', // change Karma's debug.html to the mocha web reporter
-          timeout: 10000,
+          timeout: 20000,
           slow: 5000
         }
       }

@LeeDr LeeDr added the test label Nov 4, 2016
@LeeDr LeeDr mentioned this pull request Nov 4, 2016
@LeeDr LeeDr added the review label Nov 4, 2016
@BigFunger
Copy link
Contributor

The tests you listed are passing for me on master in just over 3 seconds.

untitled

@epixa
Copy link
Contributor

epixa commented Dec 26, 2016

The build on this is failing

@LeeDr LeeDr closed this May 23, 2017
@LeeDr LeeDr deleted the fixWindowsIeTestTimeouts branch May 23, 2017 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants