-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix values of products.min_price
field in Kibana sample ecommerce data set
#90428
Conversation
…hat these are floating point numbers
hey @przemekwitek, thanks for creating a PR! |
@przemekwitek @darnautov We should update both of our ecommerce based test datasets (ecommerce and module_sample_ecommerce). Could be done as part of this PR or, if we want to keep the scope small, I can do it in a follow-up PR. |
…/ml/ecommerce/data.json.gz
…/ml/module_sample_ecommerce/data.json.gz
Done.
Done.
Done as part of this PR. |
@przemekwitek might be you need to adjust mappings here kibana/src/plugins/home/server/services/sample_data/data_sets/ecommerce/field_mappings.ts Line 9 in 4584a8b
Edit: it's |
The test archive data changes are looking good, but we still get the following error in the ES log when the
I couldn't find the root cause of this yet. |
I couldn't find the root cause either. |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test data change LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing the data sets!
…ndition-for-hiding-recommded-allocation * 'master' of github.com:elastic/kibana: [Discover] Fix toggling multi fields from doc view table (elastic#91121) [ML] Data Frame Analytics: ROC Curve Chart (elastic#89991) skip flaky suite (elastic#86948) skip flaky suite (elastic#91191) Fix date histogram time zone for rollup index (elastic#90632) [Search Source] Fix retrieval of unmapped fields; Add field filters (elastic#89837) [Logs UI] Use useMlHref hook for ML links (elastic#90935) Fix values of `products.min_price` field in Kibana sample ecommerce data set (elastic#90428) [APM] Darker shade for Error group details labels (elastic#91349) [Lens] Adjust new copy for 7.12 (elastic#90413) [ML] Unskip test. Fix modelMemoryLimit value. (elastic#91280) [Lens] Fix empty display name issue in XY chart (elastic#91132) [Lens] Improves error messages when in Dashboard (elastic#90668) [Lens] Keyboard-selected items follow user traversal of drop zones (elastic#90546) [Lens] Improves ranking feature in Top values (elastic#90749) [ILM] Rollover min age tooltip and copy fixes (elastic#91110) # Conflicts: # x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/edit_policy.test.ts
This PR adds
.01
suffix to theproducts.min_price
integer values so that all theproducts.min_price
values are floating point numbers.This change prevents dynamic mappings to kick in when reindexing or transforming this index.
cloning.ts
andediting.ts
functional tests are not re-enabled as part of this PR. This will be handled separately.Relates elastic/elasticsearch#67148