Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable and debug flaky tags test #90762

Merged
merged 4 commits into from
Feb 15, 2021
Merged

Conversation

rudolf
Copy link
Contributor

@rudolf rudolf commented Feb 9, 2021

Summary

Closes #90552

The DELETE tag test sometimes failed with a 400 code where supertest expected a 200 but I've been unable to track down where exactly this happens and without knowing what the response body is, it's hard to fix. So I added this debugging but after > 80 test runs it still hasn't failed so I'll enable the test again and if there's more failures we should have more information to fix it.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@rudolf rudolf added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Feb 9, 2021
@rudolf rudolf requested a review from a team as a code owner February 9, 2021 12:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So basically we'll be waiting for the test to get flaky again but this time wwe have additional tracing. We have a similar case with ui counters api_integration tests (SO does not get incremented correctly even though we use refresh=wait_for)

@rudolf
Copy link
Contributor Author

rudolf commented Feb 10, 2021

@elasticmachine merge upstream

@rudolf
Copy link
Contributor Author

rudolf commented Feb 15, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rudolf rudolf merged commit bbc24b3 into elastic:master Feb 15, 2021
@rudolf rudolf deleted the tag-flakiness branch February 15, 2021 15:55
rudolf added a commit to rudolf/kibana that referenced this pull request Feb 15, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
rudolf added a commit that referenced this pull request Feb 15, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.12.0 v8.0.0
Projects
None yet
4 participants